Source/core/css/CSSShadowValue.cpp - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSShadowValue.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSShadowValue.cpp

diff --git a/Source/core/css/CSSShadowValue.cpp b/Source/core/css/CSSShadowValue.cpp

index 2b25ab08edecab51c13bfed9390a25e3306c69ca..3473b2a8a5194689fd4df7105ce450c6ca68d93f 100644

--- a/Source/core/css/CSSShadowValue.cpp

+++ b/Source/core/css/CSSShadowValue.cpp

@@ -27,12 +27,12 @@

namespace blink {

// Used for text-shadow and box-shadow

-CSSShadowValue::CSSShadowValue(NullableCSSValue x,

- NullableCSSValue y,

- NullableCSSValue blur,

- NullableCSSValue spread,

- NullableCSSValue style,

- NullableCSSValue color)

+CSSShadowValue::CSSShadowValue(const NullableCSSValue& x,

+ const NullableCSSValue& y,

+ const NullableCSSValue& blur,

+ const NullableCSSValue& spread,

+ const NullableCSSValue& style,

+ const NullableCSSValue& color)

: CSSValueObject(ShadowClass)

, x(x)

, y(y)

« no previous file with comments | « Source/core/css/CSSShadowValue.h ('k') | Source/core/css/CSSValue.h » ('j') | no next file with comments »