CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Source/core/css/parser/CSSPropertyParser.h

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 - 2010  Torch Mobile (Beijing) Co. Ltd. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
@@ skipping 74 matching lines @@
 
     bool inShorthand() const { return m_inParseShorthand; }
     bool inQuirksMode() const { return isQuirksModeBehavior(m_context.mode()); }
 
     bool parseViewportProperty(CSSPropertyID propId, bool important);
     bool parseViewportShorthand(CSSPropertyID propId, CSSPropertyID first, CSSPropertyID second, bool important);
     bool parseFontFaceDescriptor(CSSPropertyID);
 
     KURL completeURL(const String& url) const;
 
-    void addProperty(CSSPropertyID, CSSValue, bool important, bool implicit = false);
+    void addProperty(CSSPropertyID, const CSSValue&, bool important, bool implicit = false);
     void rollbackLastProperties(int num);
     void addExpandedPropertyForValue(CSSPropertyID propId, CSSValue, bool);
 
     NullableCSSValue parseValidPrimitive(CSSValueID ident, CSSParserValue*);
 
     bool parseShorthand(CSSPropertyID, const StylePropertyShorthand&, bool important);
     bool parse4Values(CSSPropertyID, const CSSPropertyID* properties, bool important);
     PassRefPtrWillBeRawPtr<CSSValueList> parseContent();
     NullableCSSValue parseQuotes();
 
     NullableCSSValue parseAttr(CSSParserValueList* args);
 
     bool parseFillImage(CSSParserValueList*, NullableCSSValue&);
 
     enum FillPositionFlag { InvalidFillPosition = 0, AmbiguousFillPosition = 1, XFillPosition = 2, YFillPosition = 4 };
     enum FillPositionParsingMode { ResolveValuesAsPercent = 0, ResolveValuesAsKeyword = 1 };
     NullableCSSValue parseFillPositionComponent(CSSParserValueList*, unsigned& cumulativeFlags, FillPositionFlag& individualFlag, FillPositionParsingMode = ResolveValuesAsPercent, Units = FUnknown);
     NullableCSSValue parseFillPositionX(CSSParserValueList*);
     NullableCSSValue parseFillPositionY(CSSParserValueList*);
     void parse2ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, Units = FUnknown);
     bool isPotentialPositionValue(CSSParserValue*);
     void parseFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, Units = FUnknown);
-    void parse3ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, CSSPrimitiveValue, CSSPrimitiveValue);
-    void parse4ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, CSSPrimitiveValue, CSSPrimitiveValue);
+    void parse3ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, const CSSPrimitiveValue&, const CSSPrimitiveValue&);
+    void parse4ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, const CSSPrimitiveValue&, const CSSPrimitiveValue&);
 
     void parseFillRepeat(NullableCSSValue&, NullableCSSValue&);
     NullableCSSValue parseFillSize(CSSPropertyID);
 
     bool parseFillProperty(CSSPropertyID propId, CSSPropertyID& propId1, CSSPropertyID& propId2, NullableCSSValue&, NullableCSSValue&);
     bool parseFillShorthand(CSSPropertyID, const CSSPropertyID* properties, int numProperties, bool important);
 
-    void addFillValue(NullableCSSValue& lval, CSSValue rval);
+    void addFillValue(NullableCSSValue& lval, const CSSValue& rval);
 
     NullableCSSValue parseAnimationDelay();
     NullableCSSValue parseAnimationDirection();
     NullableCSSValue parseAnimationDuration();
     NullableCSSValue parseAnimationFillMode();
     NullableCSSValue parseAnimationIterationCount();
     NullableCSSValue parseAnimationName(bool allowQuotedName);
     NullableCSSValue parseAnimationPlayState();
     NullableCSSValue parseAnimationProperty();
     NullableCSSValue parseAnimationTimingFunction();
@@ skipping 216 matching lines @@
     bool validUnit(CSSParserValue*, Units, CSSParserMode, ReleaseParsedCalcValueCondition releaseCalc = DoNotReleaseParsedCalcValue);
 
     bool parseBorderImageQuad(Units, NullableCSSValue&);
     int colorIntFromValue(CSSParserValue*);
     bool isCalculation(CSSParserValue*);
 
     bool buildBorderImageParseContext(CSSPropertyID, BorderImageParseContext&);
 
     bool parseDeprecatedGradientColorStop(CSSParserValue*, CSSGradientColorStop&);
 
-    void commitBorderImageProperty(CSSPropertyID, NullableCSSValue, bool important);
+    void commitBorderImageProperty(CSSPropertyID, const NullableCSSValue&, bool important);
 
     NullableCSSValue parseScrollSnapPoints();
     NullableCSSValue parseScrollSnapDestination();
     NullableCSSValue parseScrollSnapCoordinate();
     NullableCSSValue parseScrollSnapPosition();
 
 private:
     // Inputs:
     CSSParserValueList* m_valueList;
     const CSSParserContext& m_context;
 
     // Outputs:
     WillBeHeapVector<CSSProperty, 256>& m_parsedProperties;
     StyleRule::Type m_ruleType;
 
     // Locals during parsing:
     int m_inParseShorthand;
     CSSPropertyID m_currentShorthand;
     bool m_implicitShorthand;
     RefPtrWillBeMember<CSSCalcValue> m_parsedCalculation;
 };
 
 CSSPropertyID unresolvedCSSPropertyID(const CSSParserString&);
 CSSValueID cssValueKeywordID(const CSSParserString&);
 
 } // namespace blink
 
 #endif // CSSPropertyParser_h