Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: Source/core/css/FontFace.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/FontFace.h ('k') | Source/core/css/Pair.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/FontFace.cpp
diff --git a/Source/core/css/FontFace.cpp b/Source/core/css/FontFace.cpp
index 7404133588ae3aeb73671b8dacb5db59e07750bd..bd6f9ccc312f59ed9218937df0722479603de567 100644
--- a/Source/core/css/FontFace.cpp
+++ b/Source/core/css/FontFace.cpp
@@ -242,7 +242,7 @@ bool FontFace::setPropertyFromStyle(const StylePropertySet& properties, CSSPrope
return setPropertyValue(properties.getPropertyCSSValue(propertyID), propertyID);
}
-bool FontFace::setPropertyValue(NullableCSSValue value, CSSPropertyID propertyID)
+bool FontFace::setPropertyValue(const NullableCSSValue& value, CSSPropertyID propertyID)
{
switch (propertyID) {
case CSSPropertyFontStyle:
@@ -278,7 +278,7 @@ bool FontFace::setFamilyValue(CSSValueList* familyList)
if (familyList->length() != 1)
return false;
- CSSPrimitiveValue familyValue = toCSSPrimitiveValue(familyList->item(0));
+ const CSSPrimitiveValue& familyValue = toCSSPrimitiveValue(familyList->item(0));
AtomicString family;
if (familyValue.isCustomIdent()) {
family = AtomicString(familyValue.getStringValue());
@@ -511,7 +511,7 @@ static PassOwnPtrWillBeRawPtr<CSSFontFace> createCSSFontFace(FontFace* fontFace,
return adoptPtrWillBeNoop(new CSSFontFace(fontFace, ranges));
}
-void FontFace::initCSSFontFace(Document* document, CSSValue src)
+void FontFace::initCSSFontFace(Document* document, const CSSValue& src)
{
m_cssFontFace = createCSSFontFace(this, m_unicodeRange);
if (m_error)
« no previous file with comments | « Source/core/css/FontFace.h ('k') | Source/core/css/Pair.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698