Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: Source/core/css/parser/CSSPropertyParser.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/parser/CSSParser.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.h
diff --git a/Source/core/css/parser/CSSPropertyParser.h b/Source/core/css/parser/CSSPropertyParser.h
index 11d42e32612f18e2fa6c3caa8de9ca0fb2672c9c..d236738a4d4a9acfb21826d6505ed8895b16e314 100644
--- a/Source/core/css/parser/CSSPropertyParser.h
+++ b/Source/core/css/parser/CSSPropertyParser.h
@@ -92,7 +92,7 @@ private:
KURL completeURL(const String& url) const;
- void addProperty(CSSPropertyID, CSSValue, bool important, bool implicit = false);
+ void addProperty(CSSPropertyID, const CSSValue&, bool important, bool implicit = false);
void rollbackLastProperties(int num);
void addExpandedPropertyForValue(CSSPropertyID propId, CSSValue, bool);
@@ -115,8 +115,8 @@ private:
void parse2ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, Units = FUnknown);
bool isPotentialPositionValue(CSSParserValue*);
void parseFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, Units = FUnknown);
- void parse3ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, CSSPrimitiveValue, CSSPrimitiveValue);
- void parse4ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, CSSPrimitiveValue, CSSPrimitiveValue);
+ void parse3ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, const CSSPrimitiveValue&, const CSSPrimitiveValue&);
+ void parse4ValuesFillPosition(CSSParserValueList*, NullableCSSValue&, NullableCSSValue&, const CSSPrimitiveValue&, const CSSPrimitiveValue&);
void parseFillRepeat(NullableCSSValue&, NullableCSSValue&);
NullableCSSValue parseFillSize(CSSPropertyID);
@@ -124,7 +124,7 @@ private:
bool parseFillProperty(CSSPropertyID propId, CSSPropertyID& propId1, CSSPropertyID& propId2, NullableCSSValue&, NullableCSSValue&);
bool parseFillShorthand(CSSPropertyID, const CSSPropertyID* properties, int numProperties, bool important);
- void addFillValue(NullableCSSValue& lval, CSSValue rval);
+ void addFillValue(NullableCSSValue& lval, const CSSValue& rval);
NullableCSSValue parseAnimationDelay();
NullableCSSValue parseAnimationDirection();
@@ -361,7 +361,7 @@ private:
bool parseDeprecatedGradientColorStop(CSSParserValue*, CSSGradientColorStop&);
- void commitBorderImageProperty(CSSPropertyID, NullableCSSValue, bool important);
+ void commitBorderImageProperty(CSSPropertyID, const NullableCSSValue&, bool important);
NullableCSSValue parseScrollSnapPoints();
NullableCSSValue parseScrollSnapDestination();
« no previous file with comments | « Source/core/css/parser/CSSParser.cpp ('k') | Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698