CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Source/core/css/CSSBasicShapes.cpp

 /*
  * Copyright (C) 2011 Adobe Systems Incorporated. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 51 matching lines @@
     result.append(')');
     if (box.length()) {
         result.appendLiteral(separator);
         result.append(box);
     }
     return result.toString();
 }
 
 static String serializePositionOffset(const Pair& offset, const Pair& other)
 {
-    if ((toCSSPrimitiveValue(*offset.first()).getValueID() == CSSValueLeft && toCSSPrimitiveValue(*other.first()).getValueID() == CSSValueTop)
-        || (toCSSPrimitiveValue(*offset.first()).getValueID() == CSSValueTop && toCSSPrimitiveValue(*other.first()).getValueID() == CSSValueLeft))
-        return offset.second()->cssText();
+    if ((offset.first().getValueID() == CSSValueLeft && other.first().getValueID() == CSSValueTop)
+        || (offset.first().getValueID() == CSSValueTop && other.first().getValueID() == CSSValueLeft))
+        return offset.second().cssText();
     return offset.cssText();
 }
 
-static CSSPrimitiveValue buildSerializablePositionOffset(NullableCSSValue offset, CSSValueID defaultSide)
+static CSSPrimitiveValue buildSerializablePositionOffset(const NullableCSSValue& offset, CSSValueID defaultSide)
 {
     CSSValueID side = defaultSide;
     NullableCSSValue amount;
 
     if (!offset) {
         side = CSSValueCenter;
     } else if (toCSSPrimitiveValue(*offset).isValueID()) {
         side = toCSSPrimitiveValue(*offset).getValueID();
     } else if (Pair* pair = toCSSPrimitiveValue(*offset).getPairValue()) {
-        side = toCSSPrimitiveValue(*pair->first()).getValueID();
+        side = pair->first().getValueID();
         amount = pair->second();
     } else {
         amount = offset;
     }
 
     if (side == CSSValueCenter) {
         side = defaultSide;
         amount = cssValuePool().createValue(50, CSSPrimitiveValue::CSS_PERCENTAGE);
     } else if ((side == CSSValueRight || side == CSSValueBottom)
         && toCSSPrimitiveValue(*amount).isPercentage()) {
@@ skipping 272 matching lines @@
                     result.append(verticalRadii[i]);
                 }
             }
         }
     }
     result.append(')');
 
     return result.toString();
 }
 
-static inline void updateCornerRadiusWidthAndHeight(NullableCSSValue corner, String& width, String& height)
+static inline void updateCornerRadiusWidthAndHeight(const NullableCSSValue& corner, String& width, String& height)
 {
     if (!corner)
         return;
 
     Pair* radius = toCSSPrimitiveValue(*corner).getPairValue();
-    width = radius->first() ? radius->first()->cssText() : String("0");
-    if (radius->second())
-        height = radius->second()->cssText();
+    width = radius->first().cssText();
+    height = radius->second().cssText();
 }
 
 String CSSBasicShapeInset::cssText() const
 {
     String topLeftRadiusWidth;
     String topLeftRadiusHeight;
     String topRightRadiusWidth;
     String topRightRadiusHeight;
     String bottomRightRadiusWidth;
     String bottomRightRadiusHeight;
@@ skipping 43 matching lines @@
     visitor->trace(m_left);
     visitor->trace(m_topLeftRadius);
     visitor->trace(m_topRightRadius);
     visitor->trace(m_bottomRightRadius);
     visitor->trace(m_bottomLeftRadius);
     CSSBasicShape::trace(visitor);
 }
 
 } // namespace blink