Source/build/scripts/templates/StyleBuilder.cpp.tmpl - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/build/scripts/templates/StyleBuilder.cpp.tmpl

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/build/scripts/templates/StyleBuilder.cpp.tmpl

diff --git a/Source/build/scripts/templates/StyleBuilder.cpp.tmpl b/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

index cc09fbd0470bc43c7d1d6370877e4d80b230bcd2..e9d53cb6657d081762473bf6fb816a838b398e28 100644

--- a/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

+++ b/Source/build/scripts/templates/StyleBuilder.cpp.tmpl

@@ -13,7 +13,7 @@

namespace blink {

-void StyleBuilder::applyProperty(CSSPropertyID property, StyleResolverState& state, CSSValue value, bool isInitial, bool isInherit) {

+void StyleBuilder::applyProperty(CSSPropertyID property, StyleResolverState& state, const CSSValue& value, bool isInitial, bool isInherit) {

switch(property) {

{% for property_id, property in properties.items()

if property.should_declare_functions or property.use_handlers_for %}

« no previous file with comments | « no previous file | Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl » ('j') | no next file with comments »