Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: Source/core/css/Counter.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSValueTest.cpp ('k') | Source/core/css/FontFace.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 10 matching lines...) Expand all
21 #ifndef Counter_h 21 #ifndef Counter_h
22 #define Counter_h 22 #define Counter_h
23 23
24 #include "core/css/CSSValue.h" 24 #include "core/css/CSSValue.h"
25 #include "wtf/text/WTFString.h" 25 #include "wtf/text/WTFString.h"
26 26
27 namespace blink { 27 namespace blink {
28 28
29 class Counter : public RefCountedWillBeGarbageCollectedFinalized<Counter> { 29 class Counter : public RefCountedWillBeGarbageCollectedFinalized<Counter> {
30 public: 30 public:
31 static PassRefPtrWillBeRawPtr<Counter> create(CSSPrimitiveValue identifier, CSSPrimitiveValue listStyle, CSSPrimitiveValue separator) 31 static PassRefPtrWillBeRawPtr<Counter> create(const CSSPrimitiveValue& ident ifier, const CSSPrimitiveValue& listStyle, const CSSPrimitiveValue& separator)
32 { 32 {
33 return adoptRefWillBeNoop(new Counter(identifier, listStyle, separator)) ; 33 return adoptRefWillBeNoop(new Counter(identifier, listStyle, separator)) ;
34 } 34 }
35 35
36 String identifier() const { return toCSSPrimitiveValue(m_identifier).getStri ngValue(); } 36 String identifier() const { return toCSSPrimitiveValue(m_identifier).getStri ngValue(); }
37 String listStyle() const { return toCSSPrimitiveValue(m_listStyle).getString Value(); } 37 String listStyle() const { return toCSSPrimitiveValue(m_listStyle).getString Value(); }
38 String separator() const { return toCSSPrimitiveValue(m_separator).getString Value(); } 38 String separator() const { return toCSSPrimitiveValue(m_separator).getString Value(); }
39 39
40 CSSValueID listStyleIdent() const { return toCSSPrimitiveValue(m_listStyle). getValueID(); } 40 CSSValueID listStyleIdent() const { return toCSSPrimitiveValue(m_listStyle). getValueID(); }
41 41
42 void setIdentifier(CSSPrimitiveValue identifier) { m_identifier = identifier ; } 42 void setIdentifier(const CSSPrimitiveValue& identifier) { m_identifier = ide ntifier; }
43 void setListStyle(CSSPrimitiveValue listStyle) { m_listStyle = listStyle; } 43 void setListStyle(const CSSPrimitiveValue& listStyle) { m_listStyle = listSt yle; }
44 void setSeparator(CSSPrimitiveValue separator) { m_separator = separator; } 44 void setSeparator(const CSSPrimitiveValue& separator) { m_separator = separa tor; }
45 45
46 bool equals(const Counter& other) const 46 bool equals(const Counter& other) const
47 { 47 {
48 return identifier() == other.identifier() 48 return identifier() == other.identifier()
49 && listStyle() == other.listStyle() 49 && listStyle() == other.listStyle()
50 && separator() == other.separator(); 50 && separator() == other.separator();
51 } 51 }
52 52
53 DECLARE_TRACE(); 53 DECLARE_TRACE();
54 54
55 private: 55 private:
56 Counter(CSSPrimitiveValue identifier, CSSPrimitiveValue listStyle, CSSPrimit iveValue separator) 56 Counter(const CSSPrimitiveValue& identifier, const CSSPrimitiveValue& listSt yle, const CSSPrimitiveValue& separator)
57 : m_identifier(identifier) 57 : m_identifier(identifier)
58 , m_listStyle(listStyle) 58 , m_listStyle(listStyle)
59 , m_separator(separator) { } 59 , m_separator(separator) { }
60 60
61 CSSValue m_identifier; // string 61 CSSValue m_identifier; // string
62 CSSValue m_listStyle; // ident 62 CSSValue m_listStyle; // ident
63 CSSValue m_separator; // string 63 CSSValue m_separator; // string
64 }; 64 };
65 65
66 } // namespace blink 66 } // namespace blink
67 67
68 #endif // Counter_h 68 #endif // Counter_h
OLDNEW
« no previous file with comments | « Source/core/css/CSSValueTest.cpp ('k') | Source/core/css/FontFace.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698