Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: Source/core/animation/StringKeyframe.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/ShadowStyleInterpolation.cpp ('k') | Source/core/animation/StringKeyframe.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/StringKeyframe.h
diff --git a/Source/core/animation/StringKeyframe.h b/Source/core/animation/StringKeyframe.h
index 95b5dc142c5af278d88d42e1adc4ac77124516b1..6c21e8f820f2c72baef3bd550a9998db7a58f0de 100644
--- a/Source/core/animation/StringKeyframe.h
+++ b/Source/core/animation/StringKeyframe.h
@@ -41,9 +41,9 @@ public:
class CSSPropertySpecificKeyframe : public Keyframe::PropertySpecificKeyframe {
public:
- CSSPropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, NullableCSSValue, EffectModel::CompositeOperation);
+ CSSPropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, const NullableCSSValue&, EffectModel::CompositeOperation);
- NullableCSSValue value() const { return m_value; }
+ const NullableCSSValue& value() const { return m_value; }
virtual void populateAnimatableValue(CSSPropertyID, Element&, const ComputedStyle* baseStyle) const;
virtual const PassRefPtrWillBeRawPtr<AnimatableValue> getAnimatableValue() const override final { return m_animatableValueCache.get(); }
@@ -55,14 +55,14 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- CSSPropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, NullableCSSValue);
+ CSSPropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, const NullableCSSValue&);
virtual PassOwnPtrWillBeRawPtr<Keyframe::PropertySpecificKeyframe> cloneWithOffset(double offset) const;
virtual bool isCSSPropertySpecificKeyframe() const override { return true; }
- static bool createInterpolationsFromCSSValues(CSSPropertyID, CSSValue fromCSSValue, CSSValue toCSSValue, Element*, OwnPtrWillBeRawPtr<WillBeHeapVector<RefPtrWillBeMember<Interpolation>>>& interpolations);
+ static bool createInterpolationsFromCSSValues(CSSPropertyID, const CSSValue& fromCSSValue, const CSSValue& toCSSValue, Element*, OwnPtrWillBeRawPtr<WillBeHeapVector<RefPtrWillBeMember<Interpolation>>>& interpolations);
- void populateAnimatableValueCaches(CSSPropertyID, Keyframe::PropertySpecificKeyframe&, Element*, CSSValue& fromCSSValue, CSSValue& toCSSValue) const;
+ void populateAnimatableValueCaches(CSSPropertyID, Keyframe::PropertySpecificKeyframe&, Element*, const CSSValue& fromCSSValue, const CSSValue& toCSSValue) const;
NullableCSSValue m_value;
mutable RefPtrWillBeMember<AnimatableValue> m_animatableValueCache;
« no previous file with comments | « Source/core/animation/ShadowStyleInterpolation.cpp ('k') | Source/core/animation/StringKeyframe.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698