Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: Source/core/css/CSSCrossfadeValue.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSCrossfadeValue.h ('k') | Source/core/css/CSSCursorImageValue.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/CSSCrossfadeValue.cpp
diff --git a/Source/core/css/CSSCrossfadeValue.cpp b/Source/core/css/CSSCrossfadeValue.cpp
index 0fcf5c942c3d39f4e98f95e30070cbf389c30ddc..2aacfc24761598903e00bf5239155ca298a76fbf 100644
--- a/Source/core/css/CSSCrossfadeValue.cpp
+++ b/Source/core/css/CSSCrossfadeValue.cpp
@@ -34,7 +34,7 @@
namespace blink {
-static bool subimageIsPending(CSSValue value)
+static bool subimageIsPending(const CSSValue& value)
{
if (value.isImageValue())
return toCSSImageValue(value).cachedOrPendingImage()->isPendingImage();
@@ -47,7 +47,7 @@ static bool subimageIsPending(CSSValue value)
return false;
}
-static bool subimageKnownToBeOpaque(CSSValue value, const LayoutObject* layoutObject)
+static bool subimageKnownToBeOpaque(const CSSValue& value, const LayoutObject* layoutObject)
{
if (value.isImageValue())
return toCSSImageValue(value).knownToBeOpaque(layoutObject);
@@ -60,7 +60,7 @@ static bool subimageKnownToBeOpaque(CSSValue value, const LayoutObject* layoutOb
return false;
}
-static ImageResource* cachedImageForCSSValue(CSSValue value, Document* document)
+static ImageResource* cachedImageForCSSValue(const CSSValue& value, Document* document)
{
if (value.isImageValue()) {
StyleFetchedImage* styleImageResource = toCSSImageValue(value).cachedImage(document);
« no previous file with comments | « Source/core/css/CSSCrossfadeValue.h ('k') | Source/core/css/CSSCursorImageValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698