Source/core/dom/TextLinkColors.cpp - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/TextLinkColors.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/TextLinkColors.cpp

diff --git a/Source/core/dom/TextLinkColors.cpp b/Source/core/dom/TextLinkColors.cpp

index 805de17c41ffc04c9cbae0fb47289f7f980d4051..9a3f696fec06e8000b95bd5bffd64971abdc8ffd 100644

--- a/Source/core/dom/TextLinkColors.cpp

+++ b/Source/core/dom/TextLinkColors.cpp

@@ -94,7 +94,7 @@ static Color colorForCSSValue(CSSValueID cssValueId)

return LayoutTheme::theme().systemColor(cssValueId);

}

-Color TextLinkColors::colorFromPrimitiveValue(const CSSPrimitiveValue value, Color currentColor, bool forVisitedLink) const

+Color TextLinkColors::colorFromPrimitiveValue(const CSSPrimitiveValue& value, Color currentColor, bool forVisitedLink) const

{

if (value.isRGBColor())

return Color(value.getRGBA32Value());

« no previous file with comments | « Source/core/dom/TextLinkColors.h ('k') | Source/core/editing/ApplyStyleCommand.cpp » ('j') | no next file with comments »