Issue 1234763007: CSSValue Immediates: Make toCSSPrimitiveValue() return a const reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1234763007: CSSValue Immediates: Make toCSSPrimitiveValue() return a const reference (Closed)

Created:
5 years, 5 months ago by sashab

Modified:
5 years, 4 months ago

Reviewers:

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_3_tagged_ptrs_finally

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CSSValue Immediates: Make toCSSPrimitiveValue() return a const reference Make toCSSPrimitiveValue() return a const CSSPrimitiveValue&, to try and reduce ref-churn from calling this function. Depends on crrev.com/1226273002. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -78 lines)			Patch
M	Source/core/css/CSSPrimitiveValue.h	View	1 2 3	5 chunks	+99 lines, -48 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.cpp	View		3 chunks	+10 lines, -10 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValueTest.cpp	View		4 chunks	+96 lines, -16 lines	0 comments	Download
M	Source/core/css/CSSValue.h	View		4 chunks	+12 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 1226273002 Patch 60001

Dependent Patchsets:

Issue 1233363002 Patch 60001

Issue 1226123008 Patch 60001

Issue 1234763007: CSSValue Immediates: Make toCSSPrimitiveValue() return a const reference (Closed)

Description

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #