Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Side by Side Diff: Source/core/css/CSSShadowValue.h

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/CSSReflectValue.h ('k') | Source/core/css/CSSShadowValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 15 matching lines...) Expand all
26 #include "wtf/PassRefPtr.h" 26 #include "wtf/PassRefPtr.h"
27 #include "wtf/RefPtr.h" 27 #include "wtf/RefPtr.h"
28 28
29 namespace blink { 29 namespace blink {
30 30
31 class CSSPrimitiveValue; 31 class CSSPrimitiveValue;
32 32
33 // Used for text-shadow and box-shadow 33 // Used for text-shadow and box-shadow
34 class CORE_EXPORT CSSShadowValue : public CSSValueObject { 34 class CORE_EXPORT CSSShadowValue : public CSSValueObject {
35 public: 35 public:
36 static PassRefPtrWillBeRawPtr<CSSShadowValue> create(NullableCSSValue x, 36 static PassRefPtrWillBeRawPtr<CSSShadowValue> create(const NullableCSSValue& x,
37 NullableCSSValue y, 37 const NullableCSSValue& y,
38 NullableCSSValue blur, 38 const NullableCSSValue& blur,
39 NullableCSSValue spread, 39 const NullableCSSValue& spread,
40 NullableCSSValue style, 40 const NullableCSSValue& style,
41 NullableCSSValue color) 41 const NullableCSSValue& color)
42 { 42 {
43 return adoptRefWillBeNoop(new CSSShadowValue(x, y, blur, spread, style, color)); 43 return adoptRefWillBeNoop(new CSSShadowValue(x, y, blur, spread, style, color));
44 } 44 }
45 45
46 String customCSSText() const; 46 String customCSSText() const;
47 47
48 bool equals(const CSSShadowValue&) const; 48 bool equals(const CSSShadowValue&) const;
49 49
50 NullableCSSValue x; 50 NullableCSSValue x;
51 NullableCSSValue y; 51 NullableCSSValue y;
52 NullableCSSValue blur; 52 NullableCSSValue blur;
53 NullableCSSValue spread; 53 NullableCSSValue spread;
54 NullableCSSValue style; 54 NullableCSSValue style;
55 NullableCSSValue color; 55 NullableCSSValue color;
56 56
57 DECLARE_TRACE_AFTER_DISPATCH(); 57 DECLARE_TRACE_AFTER_DISPATCH();
58 58
59 private: 59 private:
60 CSSShadowValue(NullableCSSValue x, 60 CSSShadowValue(const NullableCSSValue& x,
61 NullableCSSValue y, 61 const NullableCSSValue& y,
62 NullableCSSValue blur, 62 const NullableCSSValue& blur,
63 NullableCSSValue spread, 63 const NullableCSSValue& spread,
64 NullableCSSValue style, 64 const NullableCSSValue& style,
65 NullableCSSValue color); 65 const NullableCSSValue& color);
66 }; 66 };
67 67
68 DEFINE_CSS_VALUE_TYPE_CASTS(CSSShadowValue, isShadowValue()); 68 DEFINE_CSS_VALUE_TYPE_CASTS(CSSShadowValue, isShadowValue());
69 69
70 } // namespace 70 } // namespace
71 71
72 #endif 72 #endif
OLDNEW
« no previous file with comments | « Source/core/css/CSSReflectValue.h ('k') | Source/core/css/CSSShadowValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698