Source/core/animation/LengthPairStyleInterpolation.cpp - Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthPairStyleInterpolation.cpp

Issue 1233363002: CSSValue Immediates: Replace CSSPrimitiveValue usage with const references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@cssvalue_patch_4_attempt_2

Patch Set: Rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/LengthBoxStyleInterpolation.cpp ('k') | Source/core/animation/LengthPairStyleInterpolationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/LengthPairStyleInterpolation.cpp

diff --git a/Source/core/animation/LengthPairStyleInterpolation.cpp b/Source/core/animation/LengthPairStyleInterpolation.cpp

index 257441b095abb0b1cd998da6baa92f125753a5e7..1dab920482f252cde1477091805e36a1728074e7 100644

--- a/Source/core/animation/LengthPairStyleInterpolation.cpp

+++ b/Source/core/animation/LengthPairStyleInterpolation.cpp

@@ -22,16 +22,16 @@ PassOwnPtrWillBeRawPtr<InterpolableValue> LengthPairStyleInterpolation::lengthPa

Pair* pair = toCSSPrimitiveValue(value).getPairValue();

ASSERT(pair);

- result->set(0, LengthStyleInterpolation::toInterpolableValue(CSSValue(*pair->first())));

- result->set(1, LengthStyleInterpolation::toInterpolableValue(CSSValue(*pair->second())));

+ result->set(0, LengthStyleInterpolation::toInterpolableValue(pair->first()));

+ result->set(1, LengthStyleInterpolation::toInterpolableValue(pair->second()));

return result.release();

}

CSSValue LengthPairStyleInterpolation::interpolableValueToLengthPair(InterpolableValue* value, InterpolationRange range)

{

InterpolableList* lengthPair = toInterpolableList(value);

- CSSPrimitiveValue first = LengthStyleInterpolation::fromInterpolableValue(*lengthPair->get(0), range);

- CSSPrimitiveValue second = LengthStyleInterpolation::fromInterpolableValue(*lengthPair->get(1), range);

+ const CSSPrimitiveValue& first = LengthStyleInterpolation::fromInterpolableValue(*lengthPair->get(0), range);

+ const CSSPrimitiveValue& second = LengthStyleInterpolation::fromInterpolableValue(*lengthPair->get(1), range);

RefPtrWillBeRawPtr<Pair> result = Pair::create(first, second, Pair::KeepIdenticalValues);

return CSSPrimitiveValue::create(result.release());