Refugee from Dead Machine 4: MDB Monster

MDB Monster

This CL contains the painful TextureAccess drawTarget linking system. It serves as a double check on the pipeline-based method. I.e., both methods need to agree.

This was last working around:

commit dad57c8c48066a2e4b270b9f6992257f7090664c
Author: joshualitt <joshualitt@google.com>;
Date:   Wed Nov 11 13:17:06 2015 -0800

    bring up SDL on windows

[robertphillips, 2015-07-08 18:34:53]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[bsalomon, 2015-07-08 19:06:36]

https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
File include/core/SkMaskFilter.h (right):

https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
include/core/SkMaskFilter.h:101: GrDrawContext* drawContext,
Wondering if we can drop GrContext here (in favor of GrTextureProvider?)

https://codereview.chromium.org/1225923010/diff/20001/include/gpu/GrDrawConte...
File include/gpu/GrDrawContext.h (right):

https://codereview.chromium.org/1225923010/diff/20001/include/gpu/GrDrawConte...
include/gpu/GrDrawContext.h:46: // This closes off other's draw commands since
at this point in its
It looks like the user of a GrDrawContext is responsible for explicitly
inserting the dependencies, but don't we have all the info we need to insert
them implicitly?

[robertphillips, 2015-07-23 18:42:45]

https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
File include/core/SkMaskFilter.h (right):

https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
include/core/SkMaskFilter.h:101: GrDrawContext* drawContext,
On 2015/07/08 19:06:36, bsalomon wrote:
> Wondering if we can drop GrContext here (in favor of GrTextureProvider?)

Done and landed in https://codereview.chromium.org/1245183002/ (Misc cleanup).

[bsalomon, 2015-08-24 13:43:11]

On 2015/07/23 18:42:45, robertphillips wrote:
>
https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
> File include/core/SkMaskFilter.h (right):
> 
>
https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
> include/core/SkMaskFilter.h:101: GrDrawContext* drawContext,
> On 2015/07/08 19:06:36, bsalomon wrote:
> > Wondering if we can drop GrContext here (in favor of GrTextureProvider?)
> 
> Done and landed in https://codereview.chromium.org/1245183002/ (Misc cleanup).

Just going through my outstanding reviews, wasn't sure if this one was waiting
on me or not.

[robertphillips, 2015-08-24 15:26:18]

On 2015/08/24 13:43:11, bsalomon wrote:
> On 2015/07/23 18:42:45, robertphillips wrote:
> >
>
https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
> > File include/core/SkMaskFilter.h (right):
> > 
> >
>
https://codereview.chromium.org/1225923010/diff/20001/include/core/SkMaskFilt...
> > include/core/SkMaskFilter.h:101: GrDrawContext* drawContext,
> > On 2015/07/08 19:06:36, bsalomon wrote:
> > > Wondering if we can drop GrContext here (in favor of GrTextureProvider?)
> > 
> > Done and landed in https://codereview.chromium.org/1245183002/ (Misc
cleanup).
> 
> Just going through my outstanding reviews, wasn't sure if this one was waiting
> on me or not.

Definitely not.

[robertphillips, 2015-10-30 18:22:49]

Description was changed from

==========
Start tightening correspondence betweeen GrDrawContext and GrRenderTarget
==========

to

==========
MDB Monster

This CL contains the painful TextureAccess drawTarget linking system. It serves
as a double check on the pipeline-based method. I.e., both methods need to
agree.
==========

[robertphillips, 2016-04-29 14:13:50]

Description was changed from

==========
MDB Monster

This CL contains the painful TextureAccess drawTarget linking system. It serves
as a double check on the pipeline-based method. I.e., both methods need to
agree.
==========

to

==========
MDB Monster

This CL contains the painful TextureAccess drawTarget linking system. It serves
as a double check on the pipeline-based method. I.e., both methods need to
agree.

This was last working around:

commit dad57c8c48066a2e4b270b9f6992257f7090664c
Author: joshualitt <joshualitt@google.com>
Date:   Wed Nov 11 13:17:06 2015 -0800

    bring up SDL on windows
==========

[robertphillips, 2016-04-29 14:13:50]

robertphillips@google.com changed reviewers:
- bsalomon@google.com