Refugee from Dead Machine 4: MDB Monster

src/effects/SkGpuBlurUtils.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkGpuBlurUtils.h"
 
 #include "SkRect.h"
@@ skipping 39 matching lines @@
                                  const SkRect& dstRect,
                                  const SkPoint& srcOffset,
                                  GrTexture* texture,
                                  Gr1DKernelEffect::Direction direction,
                                  int radius,
                                  float sigma,
                                  bool useBounds,
                                  float bounds[2]) {
     GrPaint paint;
     SkAutoTUnref<GrFragmentProcessor> conv(GrConvolutionEffect::CreateGaussian(
-        texture, direction, radius, sigma, useBounds, bounds));
+        texture, direction, radius, sigma, useBounds, bounds, drawContext->rt_remove_me()));
     paint.addColorFragmentProcessor(conv);
     SkMatrix localMatrix = SkMatrix::MakeTrans(srcOffset.x(), srcOffset.y());
     drawContext->fillRectWithLocalMatrix(clip, paint, SkMatrix::I(), dstRect, localMatrix);
 }
 
 static void convolve_gaussian_2d(GrDrawContext* drawContext,
                                  const GrClip& clip,
                                  const SkRect& srcRect,
                                  GrTexture* texture,
                                  int radiusX,
                                  int radiusY,
                                  SkScalar sigmaX,
                                  SkScalar sigmaY,
                                  const SkRect* srcBounds) {
     SkRect dstRect = SkRect::MakeWH(srcRect.width(), srcRect.height());
     SkMatrix localMatrix = SkMatrix::MakeTrans(srcRect.x(), srcRect.y());
     SkISize size = SkISize::Make(2 * radiusX + 1,  2 * radiusY + 1);
     SkIPoint kernelOffset = SkIPoint::Make(radiusX, radiusY);
     GrPaint paint;
     SkIRect bounds;
     if (srcBounds) {
         srcBounds->roundOut(&bounds);
     } else {
         bounds.setEmpty();
     }
 
     SkAutoTUnref<GrFragmentProcessor> conv(GrMatrixConvolutionEffect::CreateGaussian(
             texture, bounds, size, 1.0, 0.0, kernelOffset,
             srcBounds ? GrTextureDomain::kDecal_Mode : GrTextureDomain::kIgnore_Mode,
-            true, sigmaX, sigmaY));
+            true, sigmaX, sigmaY, drawContext->rt_remove_me()));
     paint.addColorFragmentProcessor(conv);
     drawContext->fillRectWithLocalMatrix(clip, paint, SkMatrix::I(), dstRect, localMatrix);
 }
 
 static void convolve_gaussian(GrDrawContext* drawContext,
                               const GrClip& clip,
                               const SkRect& srcRect,
                               GrTexture* texture,
                               Gr1DKernelEffect::Direction direction,
                               int radius,
@@ skipping 60 matching lines @@
 
 GrTexture* GaussianBlur(GrContext* context,
                         GrTexture* srcTexture,
                         bool canClobberSrc,
                         const SkRect& dstBounds,
                         const SkRect* srcBounds,
                         float sigmaX,
                         float sigmaY,
                         GrTextureProvider::SizeConstraint constraint) {
     SkASSERT(context);
+
+    SkAutoTUnref<GrDrawContext> srcDrawContext;
+    if (srcTexture->asRenderTarget()) {
+        srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
+    }
+
     SkIRect clearRect;
     int scaleFactorX, radiusX;
     int scaleFactorY, radiusY;
     int maxTextureSize = context->caps()->maxTextureSize();
     sigmaX = adjust_sigma(sigmaX, maxTextureSize, &scaleFactorX, &radiusX);
     sigmaY = adjust_sigma(sigmaY, maxTextureSize, &scaleFactorY, &radiusY);
 
     SkPoint srcOffset = SkPoint::Make(-dstBounds.x(), -dstBounds.y());
     SkRect localDstBounds = SkRect::MakeWH(dstBounds.width(), dstBounds.height());
     SkRect localSrcBounds;
@@ skipping 17 matching lines @@
     SkASSERT(kBGRA_8888_GrPixelConfig == srcTexture->config() ||
              kRGBA_8888_GrPixelConfig == srcTexture->config() ||
              kAlpha_8_GrPixelConfig == srcTexture->config());
 
     GrSurfaceDesc desc;
     desc.fFlags = kRenderTarget_GrSurfaceFlag;
     desc.fWidth = SkScalarFloorToInt(dstBounds.width());
     desc.fHeight = SkScalarFloorToInt(dstBounds.height());
     desc.fConfig = srcTexture->config();
 
-    GrTexture* dstTexture;
-    GrTexture* tempTexture;
     SkAutoTUnref<GrTexture> temp1, temp2;
 
     temp1.reset(context->textureProvider()->createTexture(desc, constraint));
-    dstTexture = temp1.get();
+    GrTexture* dstTexture = temp1.get();
+    SkAutoTUnref<GrDrawContext> dstDrawContext(context->drawContext(dstTexture->asRenderTarget()));
+
+    SkAutoTUnref<GrDrawContext> tmpDrawContext;
+    GrTexture* tempTexture;
     if (canClobberSrc) {
         tempTexture = srcTexture;
+        tmpDrawContext.reset(SkRef(srcDrawContext.get()));
     } else {
         temp2.reset(context->textureProvider()->createTexture(desc, constraint));
         tempTexture = temp2.get();
+        tmpDrawContext.reset(context->drawContext(tempTexture->asRenderTarget()));
     }
 
-    if (nullptr == dstTexture || nullptr == tempTexture) {
+    if (srcTexture == tempTexture) {
+        SkASSERT(srcDrawContext == tmpDrawContext);
+    }
+
+    if (nullptr == dstTexture || nullptr == tempTexture || !dstDrawContext || !tmpDrawContext) {
         return nullptr;
     }
 
-    SkAutoTUnref<GrDrawContext> srcDrawContext;
-
     for (int i = 1; i < scaleFactorX || i < scaleFactorY; i *= 2) {
         GrPaint paint;
         SkMatrix matrix;
         matrix.setIDiv(srcTexture->width(), srcTexture->height());
         SkRect dstRect(srcRect);
         if (srcBounds && i == 1) {
             SkRect domain;
             matrix.mapRect(&domain, *srcBounds);
             domain.inset((i < scaleFactorX) ? SK_ScalarHalf / srcTexture->width() : 0.0f,
                          (i < scaleFactorY) ? SK_ScalarHalf / srcTexture->height() : 0.0f);
             SkAutoTUnref<const GrFragmentProcessor> fp(GrTextureDomainEffect::Create(
                 srcTexture,
                 matrix,
                 domain,
                 GrTextureDomain::kDecal_Mode,
-                GrTextureParams::kBilerp_FilterMode));
+                GrTextureParams::kBilerp_FilterMode,
+                kLocal_GrCoordSet,
+                dstTexture->asRenderTarget()));
             paint.addColorFragmentProcessor(fp);
             srcRect.offset(-srcOffset);
             srcOffset.set(0, 0);
         } else {
             GrTextureParams params(SkShader::kClamp_TileMode, GrTextureParams::kBilerp_FilterMode);
-            paint.addColorTextureProcessor(srcTexture, matrix, params);
+            paint.addColorTextureProcessor(srcTexture, matrix, params, dstTexture->asRenderTarget());
         }
         scale_rect(&dstRect, i < scaleFactorX ? 0.5f : 1.0f,
                              i < scaleFactorY ? 0.5f : 1.0f);
 
-        SkAutoTUnref<GrDrawContext> dstDrawContext(
-                                             context->drawContext(dstTexture->asRenderTarget()));
-        if (!dstDrawContext) {
-            return nullptr;
-        }
         dstDrawContext->fillRectToRect(clip, paint, SkMatrix::I(), dstRect, srcRect);
 
-        srcDrawContext.swap(dstDrawContext);
+        if (srcTexture == tempTexture) {
+            // This guy was closed by the preceding draw since a dependant read
+            // on him was created by the draw call - reopen him
+            SkASSERT(srcDrawContext == tmpDrawContext);
+            srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
+            tmpDrawContext.reset(SkRef(srcDrawContext.get()));
+        }
+
+        dstDrawContext.reset(context->drawContext(dstTexture->asRenderTarget()));
+
+        srcDrawContext.reset(SkRef(dstDrawContext.get()));
+
         srcRect = dstRect;
         srcTexture = dstTexture;
+
+        dstDrawContext.swap(tmpDrawContext);
         SkTSwap(dstTexture, tempTexture);
         localSrcBounds = srcRect;
+
+        if (srcTexture == tempTexture) {
+            SkASSERT(srcDrawContext == tmpDrawContext);
+        }
     }
 
     // For really small blurs (certainly no wider than 5x5 on desktop gpus) it is faster to just
     // launch a single non separable kernel vs two launches
     if (sigmaX > 0.0f && sigmaY > 0.0f &&
             (2 * radiusX + 1) * (2 * radiusY + 1) <= MAX_KERNEL_SIZE) {
         // We shouldn't be scaling because this is a small size blur
         SkASSERT((1 == scaleFactorX) && (1 == scaleFactorY));
 
-        SkAutoTUnref<GrDrawContext> dstDrawContext(
-                                             context->drawContext(dstTexture->asRenderTarget()));
-        if (!dstDrawContext) {
-            return nullptr;
-        }
         convolve_gaussian_2d(dstDrawContext, clip, srcRect,
                              srcTexture, radiusX, radiusY, sigmaX, sigmaY, srcBounds);
 
-        srcDrawContext.swap(dstDrawContext);
+        srcDrawContext.reset(SkRef(dstDrawContext.get()));
+
         srcRect.offsetTo(0, 0);
         srcTexture = dstTexture;
+
+        dstDrawContext.swap(tmpDrawContext);
         SkTSwap(dstTexture, tempTexture);
 
+        if (srcTexture == tempTexture) {
+            SkASSERT(srcDrawContext == tmpDrawContext);
+        }
     } else {
         srcRect = localDstBounds;
         scale_rect(&srcRect, 1.0f / scaleFactorX, 1.0f / scaleFactorY);
         srcRect.roundOut(&srcRect);
         const SkIRect srcIRect = srcRect.roundOut();
         if (sigmaX > 0.0f) {
             if (scaleFactorX > 1) {
                 // TODO: if we pass in the source draw context we don't need this here
                 if (!srcDrawContext) {
                     srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
                     if (!srcDrawContext) {
                         return nullptr;
                     }        
                 }
 
                 // Clear out a radius to the right of the srcRect to prevent the
                 // X convolution from reading garbage.
                 clearRect = SkIRect::MakeXYWH(srcIRect.fRight, srcIRect.fTop,
                                               radiusX, srcIRect.height());
                 srcDrawContext->clear(&clearRect, 0x0, false);
             }
 
-            SkAutoTUnref<GrDrawContext> dstDrawContext(
-                                             context->drawContext(dstTexture->asRenderTarget()));
-            if (!dstDrawContext) {
-                return nullptr;
-            }
             convolve_gaussian(dstDrawContext, clip, srcRect,
                               srcTexture, Gr1DKernelEffect::kX_Direction, radiusX, sigmaX,
                               srcBounds, srcOffset);
-            srcDrawContext.swap(dstDrawContext);
+            if (srcTexture == tempTexture) {
+                // This guy was closed by the preceding draw - reopen him
+                SkASSERT(srcDrawContext == tmpDrawContext);
+                srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
+                tmpDrawContext.reset(SkRef(srcDrawContext.get()));
+            }
+
+            dstDrawContext.reset(context->drawContext(dstTexture->asRenderTarget()));
+
+
+            srcDrawContext.reset(SkRef(dstDrawContext.get()));
+
             srcTexture = dstTexture;
             srcRect.offsetTo(0, 0);
+
+            dstDrawContext.swap(tmpDrawContext);
             SkTSwap(dstTexture, tempTexture);
             localSrcBounds = srcRect;
             srcOffset.set(0, 0);
         }
 
         if (sigmaY > 0.0f) {
             if (scaleFactorY > 1 || sigmaX > 0.0f) {
                 // TODO: if we pass in the source draw context we don't need this here
                 if (!srcDrawContext) {
                     srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
                     if (!srcDrawContext) {
                         return nullptr;
                     }        
                 }
 
                 // Clear out a radius below the srcRect to prevent the Y
                 // convolution from reading garbage.
                 clearRect = SkIRect::MakeXYWH(srcIRect.fLeft, srcIRect.fBottom,
                                               srcIRect.width(), radiusY);
                 srcDrawContext->clear(&clearRect, 0x0, false);
             }
 
-            SkAutoTUnref<GrDrawContext> dstDrawContext(
-                                               context->drawContext(dstTexture->asRenderTarget()));
-            if (!dstDrawContext) {
-                return nullptr;
-            }
+//            SkRect dstRect = SkRect::MakeWH(srcRect.width(), srcRect.height());
+
             convolve_gaussian(dstDrawContext, clip, srcRect,
                               srcTexture, Gr1DKernelEffect::kY_Direction, radiusY, sigmaY,
                               srcBounds, srcOffset);
 
-            srcDrawContext.swap(dstDrawContext);
+            if (srcTexture == tempTexture) {
+                // This guy was closed by the preceding draw - reopen him
+                SkASSERT(srcDrawContext == tmpDrawContext);
+                srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
+                tmpDrawContext.reset(SkRef(srcDrawContext.get()));
+            }
+
+            dstDrawContext.reset(context->drawContext(dstTexture->asRenderTarget()));
+
+            srcDrawContext.reset(SkRef(dstDrawContext.get()));
+
             srcTexture = dstTexture;
             srcRect.offsetTo(0, 0);
+
+            dstDrawContext.swap(tmpDrawContext);
             SkTSwap(dstTexture, tempTexture);
         }
     }
     const SkIRect srcIRect = srcRect.roundOut();
 
     if (scaleFactorX > 1 || scaleFactorY > 1) {
         SkASSERT(srcDrawContext);
 
         // Clear one pixel to the right and below, to accommodate bilinear
         // upsampling.
         clearRect = SkIRect::MakeXYWH(srcIRect.fLeft, srcIRect.fBottom,
                                       srcIRect.width() + 1, 1);
         srcDrawContext->clear(&clearRect, 0x0, false);
         clearRect = SkIRect::MakeXYWH(srcIRect.fRight, srcIRect.fTop,
                                       1, srcIRect.height());
         srcDrawContext->clear(&clearRect, 0x0, false);
         SkMatrix matrix;
         matrix.setIDiv(srcTexture->width(), srcTexture->height());
 
         GrPaint paint;
         // FIXME:  this should be mitchell, not bilinear.
         GrTextureParams params(SkShader::kClamp_TileMode, GrTextureParams::kBilerp_FilterMode);
-        paint.addColorTextureProcessor(srcTexture, matrix, params);
+        paint.addColorTextureProcessor(srcTexture, matrix, params, dstTexture->asRenderTarget());
 
         SkRect dstRect(srcRect);
         scale_rect(&dstRect, (float) scaleFactorX, (float) scaleFactorY);
 
-        SkAutoTUnref<GrDrawContext> dstDrawContext(
-                                context->drawContext(dstTexture->asRenderTarget()));
-        if (!dstDrawContext) {
-            return nullptr;
-        }
         dstDrawContext->fillRectToRect(clip, paint, SkMatrix::I(), dstRect, srcRect);
 
-        srcDrawContext.swap(dstDrawContext);
+        // Don't need to do this since we're exiting
+        if (false && srcTexture == tempTexture) {
+            // This guy was closed by the preceding draw - reopen him
+            SkASSERT(srcDrawContext == tmpDrawContext);
+            srcDrawContext.reset(context->drawContext(srcTexture->asRenderTarget()));
+            tmpDrawContext.reset(SkRef(srcDrawContext.get()));
+        }
+
+        dstDrawContext.reset(context->drawContext(dstTexture->asRenderTarget()));
+
+        srcDrawContext.reset(SkRef(dstDrawContext.get()));
+
         srcRect = dstRect;
         srcTexture = dstTexture;
+
+        dstDrawContext.swap(tmpDrawContext);
         SkTSwap(dstTexture, tempTexture);
+
+        // Since we're exiting some of the DC's can now be closed
     }
 
     return SkRef(srcTexture);
 }
 #endif
 
 }