Update existing uses of /wd4267 to use the GN config

Update existing uses of /wd4267 to use the GN config

This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read.

Minor updates to Win64 build, including some fixes for size_t to int conversions.

Committed: https://crrev.com/d1c719acf7db459016f425eb8018ec4208511578
Cr-Commit-Position: refs/heads/master@{#317162}

[brettw, 2015-02-18 21:08:11]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-02-18 21:29:29]

lgtm. If you actually think the third_party code will eventually get the
size_t->int things fixed, then I'm fine w/ leaving both configs listed, else, I
would eliminate the redundant ones.

https://codereview.chromium.org/929793006/diff/20001/content/common/BUILD.gn
File content/common/BUILD.gn (right):

https://codereview.chromium.org/929793006/diff/20001/content/common/BUILD.gn#...
content/common/BUILD.gn:463: }
Is this change intentional? It seems unrelated ...

Assuming you mean to include the other win64-related fixees, at least update the
description to note that there are some other non-size_t-related changes as
well.

https://codereview.chromium.org/929793006/diff/20001/content/ppapi_plugin/bro...
File content/ppapi_plugin/broker_process_dispatcher.cc (right):

https://codereview.chromium.org/929793006/diff/20001/content/ppapi_plugin/bro...
content/ppapi_plugin/broker_process_dispatcher.cc:313:
static_cast<uint32_t>(sites.size()), site_array.get());
same comment re: non-size_t-related-things.

https://codereview.chromium.org/929793006/diff/20001/net/third_party/nss/ssl/...
File net/third_party/nss/ssl/BUILD.gn (right):

https://codereview.chromium.org/929793006/diff/20001/net/third_party/nss/ssl/...
net/third_party/nss/ssl/BUILD.gn:72:
"//build/config/compiler:no_size_t_to_int_warning",
no_size_t is already disabled in no_chromium_code, so I think this one is
unneeded.

https://codereview.chromium.org/929793006/diff/20001/third_party/cld/BUILD.gn
File third_party/cld/BUILD.gn (right):

https://codereview.chromium.org/929793006/diff/20001/third_party/cld/BUILD.gn...
third_party/cld/BUILD.gn:99: "//build/config/compiler:no_size_t_to_int_warning",
same comment about no_size_t being already part of no_chromium

https://codereview.chromium.org/929793006/diff/20001/third_party/cld_2/BUILD.gn
File third_party/cld_2/BUILD.gn (right):

https://codereview.chromium.org/929793006/diff/20001/third_party/cld_2/BUILD....
third_party/cld_2/BUILD.gn:53:
"//build/config/compiler:no_size_t_to_int_warning",
and again ... I'll stop mentioning this now, but it shows up in other files,
too.

[brettw, 2015-02-19 22:51:59]

New patchsets have been uploaded after l-g-t-m from dpranke@chromium.org

[brettw, 2015-02-19 22:56:04]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-02-19 22:56:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/929793006/60001

[commit-bot: I haz the power, 2015-02-19 23:17:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-02-19 23:18:48]

Patchset 4 (id:??) landed as
https://crrev.com/d1c719acf7db459016f425eb8018ec4208511578
Cr-Commit-Position: refs/heads/master@{#317162}