Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: rlz/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pdf/BUILD.gn ('k') | sql/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: rlz/BUILD.gn
diff --git a/rlz/BUILD.gn b/rlz/BUILD.gn
index f8891370dc03b18570e47dc9bde27c0c24236478..9c44daddaab4729ed5485a224f3bad127f2260e0 100644
--- a/rlz/BUILD.gn
+++ b/rlz/BUILD.gn
@@ -55,6 +55,9 @@ source_set("rlz_lib") {
"win/lib/rlz_value_store_registry.h",
]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
public_configs = [ ":rlz_config" ]
deps = [
@@ -73,9 +76,6 @@ source_set("rlz_lib") {
"mac/lib/rlz_value_store_mac.h",
]
set_sources_assignment_filter(sources_assignment_filter)
- } else if (is_win) {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
}
}
@@ -106,6 +106,9 @@ test("rlz_unittests") {
"win/lib/machine_deal_test.cc",
]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
deps = [
":rlz_lib",
":test_support",
@@ -116,11 +119,6 @@ test("rlz_unittests") {
"//testing/gtest",
"//third_party/zlib",
]
-
- if (is_win) {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
- }
}
executable("rlz_id") {
« no previous file with comments | « pdf/BUILD.gn ('k') | sql/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698