Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: extensions/common/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/renderer/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/crypto.gni") 5 import("//build/config/crypto.gni")
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//extensions/extensions.gni") 7 import("//extensions/extensions.gni")
8 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni") 8 import("//third_party/mojo/src/mojo/public/tools/bindings/mojom.gni")
9 9
10 # GYP version: extensions/extensions.gyp:extensions_common_constants 10 # GYP version: extensions/extensions.gyp:extensions_common_constants
11 source_set("common_constants") { 11 source_set("common_constants") {
12 sources = 12 sources =
13 rebase_path(extensions_gypi_values.extensions_common_constants_sources, 13 rebase_path(extensions_gypi_values.extensions_common_constants_sources,
14 ".", 14 ".",
15 "//extensions") 15 "//extensions")
16 16 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
17 if (is_win) { 17 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
18 cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int t runcations.
19 }
20 } 18 }
21 19
22 if (enable_extensions) { 20 if (enable_extensions) {
23 mojom("mojo") { 21 mojom("mojo") {
24 sources = rebase_path(extensions_gypi_values.extensions_common_mojo_sources, 22 sources = rebase_path(extensions_gypi_values.extensions_common_mojo_sources,
25 ".", 23 ".",
26 "//extensions") 24 "//extensions")
27 } 25 }
28 26
29 # GYP version: extensions/extensions.gyp:extensions_common 27 # GYP version: extensions/extensions.gyp:extensions_common
30 source_set("common") { 28 source_set("common") {
31 sources = rebase_path(extensions_gypi_values.extensions_common_sources, 29 sources = rebase_path(extensions_gypi_values.extensions_common_sources,
32 ".", 30 ".",
33 "//extensions") 31 "//extensions")
32 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
33 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
34 34
35 deps = [ 35 deps = [
36 ":common_constants", 36 ":common_constants",
37 ":mojo", 37 ":mojo",
38 38
39 # TODO(benwells): figure out what to do with the api target and 39 # TODO(benwells): figure out what to do with the api target and
40 # api resources compiled into the chrome resource bundle. 40 # api resources compiled into the chrome resource bundle.
41 # http://crbug.com/162530 41 # http://crbug.com/162530
42 "//chrome:resources", 42 "//chrome:resources",
43 "//components/crx_file", 43 "//components/crx_file",
(...skipping 30 matching lines...) Expand all
74 sources += nonssl_sources 74 sources += nonssl_sources
75 } 75 }
76 76
77 if (enable_nacl) { 77 if (enable_nacl) {
78 nacl_sources = 78 nacl_sources =
79 rebase_path(extensions_gypi_values.extensions_common_sources_nacl, 79 rebase_path(extensions_gypi_values.extensions_common_sources_nacl,
80 ".", 80 ".",
81 "//extensions") 81 "//extensions")
82 sources += nacl_sources 82 sources += nacl_sources
83 } 83 }
84
85 if (is_win) {
86 cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
87 }
88 } 84 }
89 } # enable_extensions 85 } # enable_extensions
OLDNEW
« no previous file with comments | « extensions/browser/BUILD.gn ('k') | extensions/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698