Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Side by Side Diff: components/password_manager/core/browser/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/packed_ct_ev_whitelist/BUILD.gn ('k') | components/pdf/renderer/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/protobuf/proto_library.gni") 5 import("//third_party/protobuf/proto_library.gni")
6 6
7 if (is_android) { 7 if (is_android) {
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 } 9 }
10 10
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 "//net", 92 "//net",
93 "//sql", 93 "//sql",
94 "//third_party/protobuf:protobuf_lite", 94 "//third_party/protobuf:protobuf_lite",
95 "//url", 95 "//url",
96 ] 96 ]
97 97
98 if (is_mac) { 98 if (is_mac) {
99 # TODO(blundell): Provide the iOS login DB implementation and then 99 # TODO(blundell): Provide the iOS login DB implementation and then
100 # also exclude the POSIX one from iOS. http://crbug.com/341429 100 # also exclude the POSIX one from iOS. http://crbug.com/341429
101 sources -= [ "login_database_posix.cc" ] 101 sources -= [ "login_database_posix.cc" ]
102 } else if (is_win) {
103 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
104 cflags = [ "/wd4267" ]
105 } 102 }
106 103
104 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
105 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
107 public_configs = [ ":password_manager_config" ] 106 public_configs = [ ":password_manager_config" ]
108 107
109 # Sync (not supported in Android WebView). 108 # Sync (not supported in Android WebView).
110 if (!is_android || !is_android_webview_build) { 109 if (!is_android || !is_android_webview_build) {
111 sources += [ 110 sources += [
112 "password_syncable_service.cc", 111 "password_syncable_service.cc",
113 "password_syncable_service.h", 112 "password_syncable_service.h",
114 ] 113 ]
115 deps += [ "//sync" ] 114 deps += [ "//sync" ]
116 } 115 }
(...skipping 29 matching lines...) Expand all
146 public_deps = [ 145 public_deps = [
147 ":browser", 146 ":browser",
148 ] 147 ]
149 deps = [ 148 deps = [
150 "//base", 149 "//base",
151 "//components/autofill/core/common", 150 "//components/autofill/core/common",
152 "//testing/gmock", 151 "//testing/gmock",
153 "//testing/gtest", 152 "//testing/gtest",
154 ] 153 ]
155 } 154 }
OLDNEW
« no previous file with comments | « components/packed_ct_ev_whitelist/BUILD.gn ('k') | components/pdf/renderer/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698