Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: ui/views/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/views/examples/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni") 5 import("//build/config/features.gni")
6 import("//build/config/ui.gni") 6 import("//build/config/ui.gni")
7 import("//testing/test.gni") 7 import("//testing/test.gni")
8 8
9 gypi_values = exec_script("//build/gypi_to_gn.py", 9 gypi_values = exec_script("//build/gypi_to_gn.py",
10 [ rebase_path("views.gyp") ], 10 [ rebase_path("views.gyp") ],
11 "scope", 11 "scope",
12 [ "views.gyp" ]) 12 [ "views.gyp" ])
13 13
14 component("views") { 14 component("views") {
15 sources = gypi_values.views_sources 15 sources = gypi_values.views_sources
16 16
17 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
18 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
19
17 defines = [ "VIEWS_IMPLEMENTATION" ] 20 defines = [ "VIEWS_IMPLEMENTATION" ]
18 21
19 deps = [ 22 deps = [
20 "//base:i18n", 23 "//base:i18n",
21 "//base/third_party/dynamic_annotations", 24 "//base/third_party/dynamic_annotations",
22 "//skia", 25 "//skia",
23 "//third_party/icu", 26 "//third_party/icu",
24 "//ui/accessibility", 27 "//ui/accessibility",
25 "//ui/aura", 28 "//ui/aura",
26 "//ui/native_theme", 29 "//ui/native_theme",
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 63
61 if (is_chromeos) { 64 if (is_chromeos) {
62 sources -= [ 65 sources -= [
63 "linux_ui/status_icon_linux.cc", 66 "linux_ui/status_icon_linux.cc",
64 "linux_ui/status_icon_linux.h", 67 "linux_ui/status_icon_linux.h",
65 ] 68 ]
66 } 69 }
67 70
68 if (is_win) { 71 if (is_win) {
69 sources += gypi_values.views_win_sources 72 sources += gypi_values.views_win_sources
70 cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int t runcations.
71 libs = [ 73 libs = [
72 "imm32.lib", 74 "imm32.lib",
73 "oleacc.lib", 75 "oleacc.lib",
74 ] 76 ]
75 ldflags = [ "/DELAYLOAD:user32.dll" ] 77 ldflags = [ "/DELAYLOAD:user32.dll" ]
76 deps += [ 78 deps += [
77 "//third_party/iaccessible2", 79 "//third_party/iaccessible2",
78 "//third_party/wtl", 80 "//third_party/wtl",
79 ] 81 ]
80 } 82 }
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
278 "//testing/gtest", 280 "//testing/gtest",
279 "//ui/aura", 281 "//ui/aura",
280 "//ui/compositor", 282 "//ui/compositor",
281 "//ui/resources", 283 "//ui/resources",
282 "//ui/resources:ui_test_pak", 284 "//ui/resources:ui_test_pak",
283 "//ui/strings", 285 "//ui/strings",
284 "//ui/wm", 286 "//ui/wm",
285 ] 287 ]
286 } 288 }
287 } 289 }
OLDNEW
« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/views/examples/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698