Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: sql/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « rlz/BUILD.gn ('k') | storage/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sql/BUILD.gn
diff --git a/sql/BUILD.gn b/sql/BUILD.gn
index 7c4d3f0c7cf6b90d07c6cde0259a5772d227e72f..8b75d8009365c16261e704dd5eebb5632cd424b2 100644
--- a/sql/BUILD.gn
+++ b/sql/BUILD.gn
@@ -21,11 +21,10 @@ component("sql") {
"transaction.h",
]
- defines = [ "SQL_IMPLEMENTATION" ]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t to int.
- }
+ defines = [ "SQL_IMPLEMENTATION" ]
deps = [
"//base",
@@ -68,9 +67,8 @@ test("sql_unittests") {
"transaction_unittest.cc",
]
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t -> int
- }
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
deps = [
":sql",
« no previous file with comments | « rlz/BUILD.gn ('k') | storage/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698