Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Side by Side Diff: third_party/sqlite/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/snappy/BUILD.gn ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("sqlite_config") { 5 config("sqlite_config") {
6 include_dirs = [ "." ] 6 include_dirs = [ "." ]
7 } 7 }
8 8
9 source_set("sqlite") { 9 source_set("sqlite") {
10 sources = [ 10 sources = [
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 } 58 }
59 59
60 include_dirs = [ 60 include_dirs = [
61 "amalgamation", 61 "amalgamation",
62 "src/src", # Needed for fts2 to build. 62 "src/src", # Needed for fts2 to build.
63 ] 63 ]
64 64
65 configs -= [ "//build/config/compiler:chromium_code" ] 65 configs -= [ "//build/config/compiler:chromium_code" ]
66 configs += [ "//build/config/compiler:no_chromium_code" ] 66 configs += [ "//build/config/compiler:no_chromium_code" ]
67 67
68 if (is_win) { 68 if (is_linux) {
69 cflags += [ "/wd4267" ] # Conversion from size_t to "type".
70 } else if (is_linux) {
71 cflags += [ 69 cflags += [
72 # SQLite doesn"t believe in compiler warnings, 70 # SQLite doesn"t believe in compiler warnings,
73 # preferring testing. 71 # preferring testing.
74 # http://www.sqlite.org/faq.html#q17 72 # http://www.sqlite.org/faq.html#q17
75 "-Wno-int-to-pointer-cast", 73 "-Wno-int-to-pointer-cast",
76 "-Wno-pointer-to-int-cast", 74 "-Wno-pointer-to-int-cast",
77 ] 75 ]
78 libs = [ "dl" ] 76 libs = [ "dl" ]
79 } else if (is_mac || is_ios) { 77 } else if (is_mac || is_ios) {
80 libs = [ "CoreFoundation.framework" ] 78 libs = [ "CoreFoundation.framework" ]
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 if (is_ios) { 113 if (is_ios) {
116 source_set("sqlite_regexp") { 114 source_set("sqlite_regexp") {
117 sources = [ 115 sources = [
118 "src/ext/icu/icu.c", 116 "src/ext/icu/icu.c",
119 ] 117 ]
120 deps = [ 118 deps = [
121 "//third_party/icu", 119 "//third_party/icu",
122 ] 120 ]
123 } 121 }
124 } 122 }
OLDNEW
« no previous file with comments | « third_party/snappy/BUILD.gn ('k') | third_party/yasm/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698