third_party/smhasher/BUILD.gn - Issue 929793006: Update existing uses of /wd4267 to use the GN config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/smhasher/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/smhasher/BUILD.gn

diff --git a/third_party/smhasher/BUILD.gn b/third_party/smhasher/BUILD.gn

index e1bbb5e33897e6aa16d23852059c4f3844a7df2a..fd9088c2712e398ffec53325ffa37cce6f0ab487 100644

--- a/third_party/smhasher/BUILD.gn

+++ b/third_party/smhasher/BUILD.gn

@@ -27,9 +27,4 @@ source_set("cityhash") {

]

configs -= [ "//build/config/compiler:chromium_code" ]

configs += [ "//build/config/compiler:no_chromium_code" ]

- if (is_win) {

- # TODO(jschuh): http://code.google.com/p/smhasher/issues/detail?id=19

- cflags = [ "/wd4267" ]

- }

}

« no previous file with comments | « third_party/re2/BUILD.gn ('k') | third_party/snappy/BUILD.gn » ('j') | no next file with comments »