chrome/browser/devtools/BUILD.gn - Issue 929793006: Update existing uses of /wd4267 to use the GN config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/BUILD.gn

diff --git a/chrome/browser/devtools/BUILD.gn b/chrome/browser/devtools/BUILD.gn

index e1edca7f425c2b663bd24be1a243c548d074a9c0..a7580cbed853aa4941796217ae1d06ddd7311904 100644

--- a/chrome/browser/devtools/BUILD.gn

+++ b/chrome/browser/devtools/BUILD.gn

@@ -47,11 +47,8 @@ static_library("devtools") {

]

sources += get_target_outputs(":devtools_protocol_constants")

- if (is_win) {

- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

- cflags = [ "/wd4267" ]

- }

configs += [

+ "//build/config/compiler:no_size_t_to_int_warning",

"//build/config/compiler:wexit_time_destructors",

"//third_party/WebKit/public:debug_devtools",

]

« no previous file with comments | « cc/BUILD.gn ('k') | chrome/common/net/BUILD.gn » ('j') | no next file with comments »