Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: ash/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « apps/BUILD.gn ('k') | base/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/BUILD.gn
diff --git a/ash/BUILD.gn b/ash/BUILD.gn
index f6f0eb9c262bed365b380875f6922b35462b2f63..ed34a59a430b65c4c8a16db12c665a0669fe1c1d 100644
--- a/ash/BUILD.gn
+++ b/ash/BUILD.gn
@@ -62,7 +62,7 @@ component("ash") {
]
# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
}
if (use_x11) {
@@ -314,9 +314,7 @@ test("ash_unittests") {
]
}
- if (is_win) {
- cflags = [ "/wd4267" ]
- }
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
if (!use_x11) {
sources -= [ "host/ash_window_tree_host_x11_unittest.cc" ]
« no previous file with comments | « apps/BUILD.gn ('k') | base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698