Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: third_party/libexif/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/libjingle/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Linux should use system libexif 5 # Linux should use system libexif
6 if (!is_linux || is_chromeos) { 6 if (!is_linux || is_chromeos) {
7 7
8 # TODO(thestig): Properly support building on Linux. 8 # TODO(thestig): Properly support building on Linux.
9 config("libexif_config") { 9 config("libexif_config") {
10 include_dirs = [ "sources" ] 10 include_dirs = [ "sources" ]
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 defines = [ 46 defines = [
47 # This seems like a hack, but this is what WebKit Win does. 47 # This seems like a hack, but this is what WebKit Win does.
48 "snprintf=_snprintf", 48 "snprintf=_snprintf",
49 "inline=__inline", 49 "inline=__inline",
50 ] 50 ]
51 51
52 ldflags = [ "/DEF:" + rebase_path("libexif.def") ] 52 ldflags = [ "/DEF:" + rebase_path("libexif.def") ]
53 53
54 cflags = [ 54 cflags = [
55 "/wd4018", # size/unsigned mismatch 55 "/wd4018", # size/unsigned mismatch
56 "/wd4267", # size_t -> ExifLong truncation on amd64
57 ] 56 ]
58 57
59 # TODO(GYP): Handle /analyze switch, when it will be used in GN. 58 # TODO(GYP): Handle /analyze switch, when it will be used in GN.
60 } else if (is_linux) { 59 } else if (is_linux) {
61 libs = [ "m" ] 60 libs = [ "m" ]
62 } 61 }
63 62
64 configs -= [ "//build/config/compiler:chromium_code" ] 63 configs -= [ "//build/config/compiler:chromium_code" ]
65 configs += [ "//build/config/compiler:no_chromium_code" ] 64 configs += [ "//build/config/compiler:no_chromium_code" ]
66 65
67 public_configs = [ ":libexif_config" ] 66 public_configs = [ ":libexif_config" ]
68 } 67 }
69 } 68 }
OLDNEW
« no previous file with comments | « third_party/harfbuzz-ng/BUILD.gn ('k') | third_party/libjingle/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698