Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: media/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/config/BUILD.gn ('k') | media/cdm/ppapi/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/BUILD.gn
diff --git a/media/BUILD.gn b/media/BUILD.gn
index 864eafe9df601eeeb4b44c632277718ee7210dc5..1e7da3f215f9c69828c760f174a236bfadc5b833 100644
--- a/media/BUILD.gn
+++ b/media/BUILD.gn
@@ -252,7 +252,12 @@ component("media") {
"video/video_encode_accelerator.h",
]
- configs += [ ":media_config" ]
+ configs += [
+ ":media_config",
+ # TODO(wolenetz): Fix size_t to int trunctaion in win64.
+ # See http://crbug.com/171009
+ "//build/config/compiler:no_size_t_to_int_warning",
+ ]
all_dependent_configs = [ ":media_dependent_config" ]
cflags = []
@@ -394,8 +399,6 @@ component("media") {
"mfreadwrite.lib",
"mfuuid.lib",
]
- cflags += [ "/wd4267" ] # TODO(wolenetz): Fix size_t to int trunctaion in win64. See
- # http://crbug.com/171009
}
if (proprietary_codecs) {
@@ -579,6 +582,10 @@ test("media_unittests") {
"video/h264_poc_unittest.cc",
]
+ # TODO(wolenetz): Fix size_t to int trunctaion in win64.
+ # See http://crbug.com/171009
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
deps = [
":media",
":test_support",
@@ -649,11 +656,6 @@ test("media_unittests") {
]
}
- if (is_win && cpu_arch == "x64") {
- cflags = [ "/wd4267" ] # TODO(wolenetz): Fix size_t to int trunctaion in win64. See
- # http://crbug.com/171009
- }
-
if (is_mac || is_ios) {
deps += [ "//media/base/mac" ]
}
« no previous file with comments | « gpu/config/BUILD.gn ('k') | media/cdm/ppapi/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698