ui/views/BUILD.gn - Issue 929793006: Update existing uses of /wd4267 to use the GN config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/BUILD.gn

diff --git a/ui/views/BUILD.gn b/ui/views/BUILD.gn

index 726288c1dcefaa77939350907ba5600f32b7b4c2..be6c0da39a3d686fa05851be1a6880bf5e134a69 100644

--- a/ui/views/BUILD.gn

+++ b/ui/views/BUILD.gn

@@ -14,6 +14,9 @@ gypi_values = exec_script("//build/gypi_to_gn.py",

component("views") {

sources = gypi_values.views_sources

+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

defines = [ "VIEWS_IMPLEMENTATION" ]

deps = [

@@ -67,7 +70,6 @@ component("views") {

if (is_win) {

sources += gypi_values.views_win_sources

- cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

libs = [

"imm32.lib",

"oleacc.lib",

« no previous file with comments | « ui/message_center/BUILD.gn ('k') | ui/views/examples/BUILD.gn » ('j') | no next file with comments »