Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: third_party/cld_2/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/cld/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/cld_2/BUILD.gn
diff --git a/third_party/cld_2/BUILD.gn b/third_party/cld_2/BUILD.gn
index bede93a63c44008985f7c5c332a99109042f9d37..8098eba59cca1d871a0c744fe2ce6f7b98f0c745 100644
--- a/third_party/cld_2/BUILD.gn
+++ b/third_party/cld_2/BUILD.gn
@@ -48,10 +48,6 @@ source_set("cld2_data") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
-
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t -> int conversion.
- }
}
# As in the corresponding gyp file, this just builds the core interfaces for
@@ -66,10 +62,6 @@ source_set("cld_2") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
-
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t -> int conversion.
- }
}
source_set("cld2_platform_impl") {
@@ -94,10 +86,6 @@ static_library("cld2_static") {
]
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [ "//build/config/compiler:no_chromium_code" ]
-
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t -> int conversion.
- }
}
config("cld2_dynamic_mode_config") {
@@ -114,13 +102,9 @@ static_library("cld2_dynamic") {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
- "//build/config/compiler:no_chromium_code",
":cld2_dynamic_mode_config",
+ "//build/config/compiler:no_chromium_code",
]
-
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t -> int conversion.
- }
}
# Does not build on Windows.
@@ -144,12 +128,8 @@ if (!is_win) {
configs -= [ "//build/config/compiler:chromium_code" ]
configs += [
- "//build/config/compiler:no_chromium_code",
":cld2_dynamic_mode_config",
+ "//build/config/compiler:no_chromium_code",
]
-
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t -> int conversion.
- }
}
}
« no previous file with comments | « third_party/cld/BUILD.gn ('k') | third_party/harfbuzz-ng/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698