Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: ui/base/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/BUILD.gn ('k') | ui/base/ime/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index c3eb671786a6f9cc32fe0bf66ae60825cda805d8..a99a649521ba0bf5a5a6da19d3b5f12c7348398e 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -294,6 +294,9 @@ component("base") {
sources += [ "touch/touch_device.cc" ]
}
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
defines = [ "UI_BASE_IMPLEMENTATION" ]
public_deps = [
@@ -414,7 +417,6 @@ component("base") {
]
deps += [ "//third_party/wtl" ]
cflags = [
- "/wd4267", # TODO(jschuh): C4267: http://crbug.com/167187 size_t -> int.
"/wd4324", # Structure was padded due to __declspec(align()), which is
# uninteresting.
]
@@ -701,6 +703,9 @@ test("ui_base_unittests") {
}
}
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
deps = [
"//base",
"//base/allocator",
@@ -746,9 +751,6 @@ test("ui_base_unittests") {
"imm32.lib",
"oleacc.lib",
]
-
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
}
if (!is_win || !use_aura) {
« no previous file with comments | « ui/aura/BUILD.gn ('k') | ui/base/ime/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698