components/keyed_service/core/BUILD.gn - Issue 929793006: Update existing uses of /wd4267 to use the GN config

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/keyed_service/core/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/keyed_service/core/BUILD.gn

diff --git a/components/keyed_service/core/BUILD.gn b/components/keyed_service/core/BUILD.gn

index 2d8670efdd6ee4bf3b87053b8b47263a9c3d7c33..8585cbb3609418664db71bfcf8ece7d27173e714 100644

--- a/components/keyed_service/core/BUILD.gn

+++ b/components/keyed_service/core/BUILD.gn

@@ -26,14 +26,11 @@ component("core") {

"service_access_types.h",

]

+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]

defines = [ "KEYED_SERVICE_IMPLEMENTATION" ]

deps = [

"//base",

]

- if (is_win) {

- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

- cflags = [ "/wd4267" ]

- }

}