Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: components/keyed_service/core/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/keyed_service/content/BUILD.gn ('k') | components/packed_ct_ev_whitelist/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/keyed_service/core/BUILD.gn
diff --git a/components/keyed_service/core/BUILD.gn b/components/keyed_service/core/BUILD.gn
index 2d8670efdd6ee4bf3b87053b8b47263a9c3d7c33..8585cbb3609418664db71bfcf8ece7d27173e714 100644
--- a/components/keyed_service/core/BUILD.gn
+++ b/components/keyed_service/core/BUILD.gn
@@ -26,14 +26,11 @@ component("core") {
"service_access_types.h",
]
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
defines = [ "KEYED_SERVICE_IMPLEMENTATION" ]
deps = [
"//base",
]
-
- if (is_win) {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- cflags = [ "/wd4267" ]
- }
}
« no previous file with comments | « components/keyed_service/content/BUILD.gn ('k') | components/packed_ct_ev_whitelist/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698