Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: google_apis/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/utility/BUILD.gn ('k') | gpu/blink/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/BUILD.gn
diff --git a/google_apis/BUILD.gn b/google_apis/BUILD.gn
index 9d10b9e7e9ce5f946f783972f4a07246061c6223..1cdf686f3502f7e09b4b81a01dd5aae7f1d933d2 100644
--- a/google_apis/BUILD.gn
+++ b/google_apis/BUILD.gn
@@ -122,11 +122,10 @@ source_set("google_apis") {
"google_api_keys.h",
]
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t -> int
- }
-
- configs += [ ":key_defines" ]
+ configs += [
+ ":key_defines",
+ "//build/config/compiler:no_size_t_to_int_warning",
+ ]
deps = [
"//base",
« no previous file with comments | « extensions/utility/BUILD.gn ('k') | gpu/blink/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698