Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: url/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/views/examples/BUILD.gn ('k') | webkit/common/gpu/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 import("//url/config.gni") 6 import("//url/config.gni")
7 7
8 # Sets the USE_ICU_ALTERNATIVES_ON_ANDROID define based on the build flag. 8 # Sets the USE_ICU_ALTERNATIVES_ON_ANDROID define based on the build flag.
9 config("url_icu_config") { 9 config("url_icu_config") {
10 if (use_icu_alternatives_on_android) { 10 if (use_icu_alternatives_on_android) {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 "url_export.h", 51 "url_export.h",
52 "url_file.h", 52 "url_file.h",
53 "url_parse_file.cc", 53 "url_parse_file.cc",
54 "url_parse_internal.h", 54 "url_parse_internal.h",
55 "url_util.cc", 55 "url_util.cc",
56 "url_util.h", 56 "url_util.h",
57 ] 57 ]
58 58
59 defines = [ "URL_IMPLEMENTATION" ] 59 defines = [ "URL_IMPLEMENTATION" ]
60 60
61 configs += [ ":url_icu_config" ] 61 configs += [
62 62 ":url_icu_config",
63 if (is_win) { 63 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
64 cflags = [ "/wd4267" ] # TODO(jschuh): crbug.com/167187 fix size_t to int t runcations. 64 "//build/config/compiler:no_size_t_to_int_warning",
65 } 65 ]
66 66
67 deps = [ 67 deps = [
68 "//base", 68 "//base",
69 "//base/third_party/dynamic_annotations", 69 "//base/third_party/dynamic_annotations",
70 "//third_party/icu:icudata", 70 "//third_party/icu:icudata",
71 "//third_party/icu", 71 "//third_party/icu",
72 ] 72 ]
73 73
74 if (use_icu_alternatives_on_android) { 74 if (use_icu_alternatives_on_android) {
75 sources -= [ 75 sources -= [
(...skipping 18 matching lines...) Expand all
94 sources = [ 94 sources = [
95 "gurl_unittest.cc", 95 "gurl_unittest.cc",
96 "origin_unittest.cc", 96 "origin_unittest.cc",
97 "url_canon_icu_unittest.cc", 97 "url_canon_icu_unittest.cc",
98 "url_canon_unittest.cc", 98 "url_canon_unittest.cc",
99 "url_parse_unittest.cc", 99 "url_parse_unittest.cc",
100 "url_test_utils.h", 100 "url_test_utils.h",
101 "url_util_unittest.cc", 101 "url_util_unittest.cc",
102 ] 102 ]
103 103
104 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
105 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
106
104 #if (is_posix && !is_mac && !is_ios) { 107 #if (is_posix && !is_mac && !is_ios) {
105 # if (use_allocator!="none") { 108 # if (use_allocator!="none") {
106 # deps += "//base/allocator" 109 # deps += "//base/allocator"
107 # } 110 # }
108 #} 111 #}
109 112
110 if (is_win) {
111 cflags = [
112 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
113 "/wd4267",
114 ]
115 }
116
117 deps = [ 113 deps = [
118 ":url", 114 ":url",
119 "//base", 115 "//base",
120 "//base/test:run_all_unittests", 116 "//base/test:run_all_unittests",
121 "//testing/gtest", 117 "//testing/gtest",
122 "//third_party/icu:icuuc", 118 "//third_party/icu:icuuc",
123 ] 119 ]
124 120
125 if (use_icu_alternatives_on_android) { 121 if (use_icu_alternatives_on_android) {
126 sources -= [ "url_canon_icu_unittest.cc" ] 122 sources -= [ "url_canon_icu_unittest.cc" ]
127 deps -= [ "//third_party/icu:icuuc" ] 123 deps -= [ "//third_party/icu:icuuc" ]
128 } 124 }
129 } 125 }
130 } 126 }
OLDNEW
« no previous file with comments | « ui/views/examples/BUILD.gn ('k') | webkit/common/gpu/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698