Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: build/secondary/third_party/nss/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/secondary/third_party/cacheinvalidation/BUILD.gn ('k') | cc/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/secondary/third_party/nss/BUILD.gn
diff --git a/build/secondary/third_party/nss/BUILD.gn b/build/secondary/third_party/nss/BUILD.gn
index 768a85d87c95159fd25e1568671b67e92ed33dfd..1786dc146c354f91f8cdd77c74167808cd17da88 100644
--- a/build/secondary/third_party/nss/BUILD.gn
+++ b/build/secondary/third_party/nss/BUILD.gn
@@ -217,7 +217,10 @@ if (is_linux) {
"//build/config/win:lean_and_mean", # Won"t compile with lean and mean.
]
}
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+ "//build/config/compiler:no_size_t_to_int_warning",
+ ]
cflags = []
defines = [
@@ -230,7 +233,6 @@ if (is_linux) {
if (is_win) {
cflags = [
"/wd4554", # Check precidence.
- "/wd4267", # Conversion from size_t to "type".
]
defines += [
"XP_PC",
@@ -882,7 +884,10 @@ if (is_linux) {
if (is_win) {
configs -= [ "//build/config/win:unicode" ] # Requires 8-bit mode.
}
- configs += [ "//build/config/compiler:no_chromium_code" ]
+ configs += [
+ "//build/config/compiler:no_chromium_code",
+ "//build/config/compiler:no_size_t_to_int_warning",
+ ]
public_configs = [ ":nss_static_config" ]
cflags = []
@@ -903,7 +908,6 @@ if (is_linux) {
if (is_win) {
cflags += [
"/wd4101", # Unreferenced local variable.
- "/wd4267", # Conversion from size_t to "type".
]
}
« no previous file with comments | « build/secondary/third_party/cacheinvalidation/BUILD.gn ('k') | cc/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698