Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(962)

Side by Side Diff: third_party/cld/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 config("cld_config") { 5 config("cld_config") {
6 defines = [ "CLD_WINDOWS" ] 6 defines = [ "CLD_WINDOWS" ]
7 include_dirs = [ "." ] 7 include_dirs = [ "." ]
8 } 8 }
9 9
10 source_set("cld") { 10 source_set("cld") {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 "base/string_util.h", 86 "base/string_util.h",
87 "base/type_traits.h", 87 "base/type_traits.h",
88 "base/template_util.h", 88 "base/template_util.h",
89 ] 89 ]
90 90
91 configs -= [ 91 configs -= [
92 # We have conflicting versions of some base files. 92 # We have conflicting versions of some base files.
93 "//build/config/compiler:default_include_dirs", 93 "//build/config/compiler:default_include_dirs",
94 "//build/config/compiler:chromium_code", 94 "//build/config/compiler:chromium_code",
95 ] 95 ]
96 configs += [ "//build/config/compiler:no_chromium_code" ] 96 configs += [
97 "//build/config/compiler:no_chromium_code",
98 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
99 "//build/config/compiler:no_size_t_to_int_warning",
Dirk Pranke 2015/02/18 21:29:29 same comment about no_size_t being already part of
100 ]
97 public_configs = [ ":cld_config" ] 101 public_configs = [ ":cld_config" ]
98 102
99 if (is_win) { 103 if (is_win) {
100 defines = [ "COMPILER_MSVC" ] 104 defines = [ "COMPILER_MSVC" ]
101 cflags = [ 105 cflags = [
102 "/wd4005", # Macro defined twice. 106 "/wd4005", # Macro defined twice.
103 "/wd4006", # #undef expected an identifier. 107 "/wd4006", # #undef expected an identifier.
104 "/wd4309", # Truncation of constant value. 108 "/wd4309", # Truncation of constant value.
105 "/wd4267", # TODO(jschuh): C4267: http://crbug.com/167187 size_t -> int
106 ] 109 ]
107 } else { 110 } else {
108 defines = [ "COMPILER_GCC" ] 111 defines = [ "COMPILER_GCC" ]
109 } 112 }
110 113
111 public_deps = [ 114 public_deps = [
112 "//third_party/icu:icuuc", 115 "//third_party/icu:icuuc",
113 ] 116 ]
114 } 117 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698