Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/yasm/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | tools/json_schema_compiler/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/BUILD.gn
diff --git a/third_party/yasm/BUILD.gn b/third_party/yasm/BUILD.gn
index cd9b4532e6c8b1f9d052ac12702392d367288006..3c5215e7d48bad28333bd6073779253da507bc82 100644
--- a/third_party/yasm/BUILD.gn
+++ b/third_party/yasm/BUILD.gn
@@ -148,8 +148,6 @@ if (current_toolchain == host_toolchain) {
# re2c is missing CLOSEVOP from one switch.
if (is_posix) {
cflags = [ "-Wno-switch" ]
- } else if (is_win) {
- cflags = [ "/wd4267" ] # size_t to int conversion.
}
}
@@ -248,9 +246,7 @@ if (current_toolchain == host_toolchain) {
# directory, but the gen_x86_insn.py script does not make this easy.
include_dirs = [ yasm_gen_include_dir ]
- if (is_win) {
- cflags = [ "/wd4267" ] # size_t to int conversion.
- } else {
+ if (!is_win) {
cflags = [
"-ansi",
"-pedantic",
« no previous file with comments | « third_party/sqlite/BUILD.gn ('k') | tools/json_schema_compiler/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698