Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: pdf/BUILD.gn

Issue 929793006: Update existing uses of /wd4267 to use the GN config (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x64
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/third_party/nss/ssl/BUILD.gn ('k') | rlz/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/BUILD.gn
diff --git a/pdf/BUILD.gn b/pdf/BUILD.gn
index 49f49a4048265df980b9791f0045047715fa615b..0f74323ff5702304429df57cf6a3bfd9a50d0b93 100644
--- a/pdf/BUILD.gn
+++ b/pdf/BUILD.gn
@@ -45,6 +45,9 @@ static_library("pdf") {
"thumbnail_control.h",
]
+ # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
+
if (pdf_engine == 0) {
sources += [
"pdfium/pdfium_api_string_buffer_adapter.cc",
@@ -63,10 +66,6 @@ static_library("pdf") {
]
}
- if (is_win) {
- cflags = [ "/wd4267" ] # TODO(jschuh) size_t to int truncations.
- }
-
deps = [
"//base",
"//components/ui/zoom:ui_zoom",
« no previous file with comments | « net/third_party/nss/ssl/BUILD.gn ('k') | rlz/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698