Eliminate CreateBooleanValue from test files

Eliminate CreateBooleanValue from test files

BUG=160586
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283665

[Evan Stade, 2014-07-15 22:08:20]

This CL is a straight find/replace.

thestig:
  chrome/*
davemoore:
  chromeos/*
blundell:
  components/*

[Lei Zhang, 2014-07-15 22:19:28]

chrome/ lgtm

https://codereview.chromium.org/397793002/diff/1/chrome/browser/profiles/inco...
File chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc (right):

https://codereview.chromium.org/397793002/diff/1/chrome/browser/profiles/inco...
chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc:39: new
base::FundamentalValue(incognito_enabled ==
nit: I like "incognito_enabled == ..." on the next line as before.

[blundell, 2014-07-16 08:45:36]

//components lgtm

[DaveMoore, 2014-07-16 18:12:00]

chromeos: LGTM

[Evan Stade, 2014-07-16 21:07:05]

https://codereview.chromium.org/397793002/diff/1/chrome/browser/profiles/inco...
File chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc (right):

https://codereview.chromium.org/397793002/diff/1/chrome/browser/profiles/inco...
chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc:39: new
base::FundamentalValue(incognito_enabled ==
On 2014/07/15 22:19:28, Lei Zhang wrote:
> nit: I like "incognito_enabled == ..." on the next line as before.

this is the output of git cl format

[Evan Stade, 2014-07-16 21:07:10]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-16 21:10:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/397793002/1

[commit-bot: I haz the power, 2014-07-16 23:46:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-16 23:46:34]

Failed to apply patch for components/policy/core/common/schema_map_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/policy/core/common/schema_map_unittest.cc
  Hunk #1 FAILED at 163.
  Hunk #2 FAILED at 192.
  2 out of 2 hunks FAILED -- saving rejects to file
components/policy/core/common/schema_map_unittest.cc.rej

Patch:       components/policy/core/common/schema_map_unittest.cc
Index: components/policy/core/common/schema_map_unittest.cc
diff --git a/components/policy/core/common/schema_map_unittest.cc
b/components/policy/core/common/schema_map_unittest.cc
index
e0eb089ab7454c1cb907fb54be3b840d532e0848..dab3535cd8aad4ed7423eb0a308f0e12b320f857
100644
--- a/components/policy/core/common/schema_map_unittest.cc
+++ b/components/policy/core/common/schema_map_unittest.cc
@@ -163,8 +163,11 @@ TEST_F(SchemaMapTest, FilterBundle) {
   list.AppendString("b");
   map.Set("list", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
           list.DeepCopy(), NULL);
-  map.Set("boolean", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-          base::Value::CreateBooleanValue(true), NULL);
+  map.Set("boolean",
+          POLICY_LEVEL_MANDATORY,
+          POLICY_SCOPE_USER,
+          new base::FundamentalValue(true),
+          NULL);
   map.Set("integer", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
           base::Value::CreateIntegerValue(1), NULL);
   map.Set("null", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
@@ -192,18 +195,33 @@ TEST_F(SchemaMapTest, FilterBundle) {
   // Mismatched types are also removed.
   bundle.Clear();
   PolicyMap& badmap = bundle.Get(extension_ns);
-  badmap.Set("list", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-             base::Value::CreateBooleanValue(false), NULL);
+  badmap.Set("list",
+             POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER,
+             new base::FundamentalValue(false),
+             NULL);
   badmap.Set("boolean", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              base::Value::CreateIntegerValue(0), NULL);
-  badmap.Set("integer", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-             base::Value::CreateBooleanValue(false), NULL);
-  badmap.Set("null", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-             base::Value::CreateBooleanValue(false), NULL);
-  badmap.Set("double", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-             base::Value::CreateBooleanValue(false), NULL);
-  badmap.Set("object", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
-             base::Value::CreateBooleanValue(false), NULL);
+  badmap.Set("integer",
+             POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER,
+             new base::FundamentalValue(false),
+             NULL);
+  badmap.Set("null",
+             POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER,
+             new base::FundamentalValue(false),
+             NULL);
+  badmap.Set("double",
+             POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER,
+             new base::FundamentalValue(false),
+             NULL);
+  badmap.Set("object",
+             POLICY_LEVEL_MANDATORY,
+             POLICY_SCOPE_USER,
+             new base::FundamentalValue(false),
+             NULL);
   badmap.Set("string", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,
              NULL,
              new ExternalDataFetcher(base::WeakPtr<ExternalDataManager>(),

[Evan Stade, 2014-07-17 00:29:49]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-17 00:31:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/397793002/20001

[Evan Stade, 2014-07-17 03:20:20]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-07-17 03:21:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/estade@chromium.org/397793002/40001

[commit-bot: I haz the power, 2014-07-17 06:37:46]

Change committed as 283665