Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/files/file_path.h" 8 #include "base/files/file_path.h"
9 #include "base/prefs/pref_store_observer_mock.h" 9 #include "base/prefs/pref_store_observer_mock.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 kTestPolicy, kTestPref, base::Value::TYPE_BOOLEAN))); 99 kTestPolicy, kTestPref, base::Value::TYPE_BOOLEAN)));
100 } 100 }
101 }; 101 };
102 102
103 TEST_F(ConfigurationPolicyPrefStoreBooleanTest, GetDefault) { 103 TEST_F(ConfigurationPolicyPrefStoreBooleanTest, GetDefault) {
104 EXPECT_FALSE(store_->GetValue(kTestPref, NULL)); 104 EXPECT_FALSE(store_->GetValue(kTestPref, NULL));
105 } 105 }
106 106
107 TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) { 107 TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {
108 PolicyMap policy; 108 PolicyMap policy;
109 policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, 109 policy.Set(kTestPolicy,
110 POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false), NULL); 110 POLICY_LEVEL_MANDATORY,
111 POLICY_SCOPE_USER,
112 new base::FundamentalValue(false),
113 NULL);
111 UpdateProviderPolicy(policy); 114 UpdateProviderPolicy(policy);
112 const base::Value* value = NULL; 115 const base::Value* value = NULL;
113 EXPECT_TRUE(store_->GetValue(kTestPref, &value)); 116 EXPECT_TRUE(store_->GetValue(kTestPref, &value));
114 ASSERT_TRUE(value); 117 ASSERT_TRUE(value);
115 bool boolean_value = true; 118 bool boolean_value = true;
116 bool result = value->GetAsBoolean(&boolean_value); 119 bool result = value->GetAsBoolean(&boolean_value);
117 ASSERT_TRUE(result); 120 ASSERT_TRUE(result);
118 EXPECT_FALSE(boolean_value); 121 EXPECT_FALSE(boolean_value);
119 122
120 policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, 123 policy.Set(kTestPolicy,
121 POLICY_SCOPE_USER, base::Value::CreateBooleanValue(true), NULL); 124 POLICY_LEVEL_MANDATORY,
125 POLICY_SCOPE_USER,
126 new base::FundamentalValue(true),
127 NULL);
122 UpdateProviderPolicy(policy); 128 UpdateProviderPolicy(policy);
123 value = NULL; 129 value = NULL;
124 EXPECT_TRUE(store_->GetValue(kTestPref, &value)); 130 EXPECT_TRUE(store_->GetValue(kTestPref, &value));
125 boolean_value = false; 131 boolean_value = false;
126 result = value->GetAsBoolean(&boolean_value); 132 result = value->GetAsBoolean(&boolean_value);
127 ASSERT_TRUE(result); 133 ASSERT_TRUE(result);
128 EXPECT_TRUE(boolean_value); 134 EXPECT_TRUE(boolean_value);
129 } 135 }
130 136
131 // Test cases for integer-valued policy settings. 137 // Test cases for integer-valued policy settings.
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 .WillRepeatedly(Return(true)); 211 .WillRepeatedly(Return(true));
206 PolicyMap policy; 212 PolicyMap policy;
207 UpdateProviderPolicy(policy); 213 UpdateProviderPolicy(policy);
208 EXPECT_TRUE(observer_.initialized); 214 EXPECT_TRUE(observer_.initialized);
209 EXPECT_TRUE(observer_.initialization_success); 215 EXPECT_TRUE(observer_.initialization_success);
210 Mock::VerifyAndClearExpectations(&observer_); 216 Mock::VerifyAndClearExpectations(&observer_);
211 EXPECT_TRUE(store_->IsInitializationComplete()); 217 EXPECT_TRUE(store_->IsInitializationComplete());
212 } 218 }
213 219
214 } // namespace policy 220 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698