components/policy/core/browser/autofill_policy_handler_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Side by Side Diff: components/policy/core/browser/autofill_policy_handler_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/policy/core/browser/configuration_policy_pref_store_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/prefs/pref_value_map.h"	5 #include "base/prefs/pref_value_map.h"

6 #include "base/values.h"	6 #include "base/values.h"

7 #include "components/autofill/core/common/autofill_pref_names.h"	7 #include "components/autofill/core/common/autofill_pref_names.h"

8 #include "components/policy/core/browser/autofill_policy_handler.h"	8 #include "components/policy/core/browser/autofill_policy_handler.h"

9 #include "components/policy/core/common/policy_map.h"	9 #include "components/policy/core/common/policy_map.h"

10 #include "policy/policy_constants.h"	10 #include "policy/policy_constants.h"

(...skipping 10 matching lines...) Expand all Loading...
21 AutofillPolicyHandler handler;	21 AutofillPolicyHandler handler;

22 handler.ApplyPolicySettings(policy, &prefs);	22 handler.ApplyPolicySettings(policy, &prefs);

23 EXPECT_FALSE(prefs.GetValue(autofill::prefs::kAutofillEnabled, NULL));	23 EXPECT_FALSE(prefs.GetValue(autofill::prefs::kAutofillEnabled, NULL));

24 }	24 }

25	25

26 TEST_F(AutofillPolicyHandlerTest, Enabled) {	26 TEST_F(AutofillPolicyHandlerTest, Enabled) {

27 PolicyMap policy;	27 PolicyMap policy;

28 policy.Set(key::kAutoFillEnabled,	28 policy.Set(key::kAutoFillEnabled,

29 POLICY_LEVEL_MANDATORY,	29 POLICY_LEVEL_MANDATORY,

30 POLICY_SCOPE_USER,	30 POLICY_SCOPE_USER,

31 base::Value::CreateBooleanValue(true),	31 new base::FundamentalValue(true),

32 NULL);	32 NULL);

33 PrefValueMap prefs;	33 PrefValueMap prefs;

34 AutofillPolicyHandler handler;	34 AutofillPolicyHandler handler;

35 handler.ApplyPolicySettings(policy, &prefs);	35 handler.ApplyPolicySettings(policy, &prefs);

36	36

37 // Enabling Autofill should not set the pref.	37 // Enabling Autofill should not set the pref.

38 EXPECT_FALSE(prefs.GetValue(autofill::prefs::kAutofillEnabled, NULL));	38 EXPECT_FALSE(prefs.GetValue(autofill::prefs::kAutofillEnabled, NULL));

39 }	39 }

40	40

41 TEST_F(AutofillPolicyHandlerTest, Disabled) {	41 TEST_F(AutofillPolicyHandlerTest, Disabled) {

42 PolicyMap policy;	42 PolicyMap policy;

43 policy.Set(key::kAutoFillEnabled,	43 policy.Set(key::kAutoFillEnabled,

44 POLICY_LEVEL_MANDATORY,	44 POLICY_LEVEL_MANDATORY,

45 POLICY_SCOPE_USER,	45 POLICY_SCOPE_USER,

46 base::Value::CreateBooleanValue(false),	46 new base::FundamentalValue(false),

47 NULL);	47 NULL);

48 PrefValueMap prefs;	48 PrefValueMap prefs;

49 AutofillPolicyHandler handler;	49 AutofillPolicyHandler handler;

50 handler.ApplyPolicySettings(policy, &prefs);	50 handler.ApplyPolicySettings(policy, &prefs);

51	51

52 // Disabling Autofill should switch the pref to managed.	52 // Disabling Autofill should switch the pref to managed.

53 const base::Value* value = NULL;	53 const base::Value* value = NULL;

54 EXPECT_TRUE(prefs.GetValue(autofill::prefs::kAutofillEnabled, &value));	54 EXPECT_TRUE(prefs.GetValue(autofill::prefs::kAutofillEnabled, &value));

55 ASSERT_TRUE(value);	55 ASSERT_TRUE(value);

56 bool autofill_enabled = true;	56 bool autofill_enabled = true;

57 bool result = value->GetAsBoolean(&autofill_enabled);	57 bool result = value->GetAsBoolean(&autofill_enabled);

58 ASSERT_TRUE(result);	58 ASSERT_TRUE(result);

59 EXPECT_FALSE(autofill_enabled);	59 EXPECT_FALSE(autofill_enabled);

60 }	60 }

61	61

62 } // namespace policy	62 } // namespace policy

OLD	NEW