Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: tools/json_schema_compiler/test/crossref_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/crossref_unittest.cc
diff --git a/tools/json_schema_compiler/test/crossref_unittest.cc b/tools/json_schema_compiler/test/crossref_unittest.cc
index 30e565ba70259de2c65eecc80692890de3d59442..42550addd2d83d282d77349c6e495bf78dd3bea2 100644
--- a/tools/json_schema_compiler/test/crossref_unittest.cc
+++ b/tools/json_schema_compiler/test/crossref_unittest.cc
@@ -17,8 +17,7 @@ static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() {
value->SetWithoutPathExpansion("integer", new base::FundamentalValue(4));
value->SetWithoutPathExpansion("string",
base::Value::CreateStringValue("bling"));
- value->SetWithoutPathExpansion("boolean",
- base::Value::CreateBooleanValue(true));
+ value->SetWithoutPathExpansion("boolean", new base::FundamentalValue(true));
return scoped_ptr<base::DictionaryValue>(value);
}
@@ -77,7 +76,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
scoped_ptr<base::DictionaryValue> param_object_value(
new base::DictionaryValue());
param_object_value->Set("testType", CreateTestTypeDictionary().release());
- param_object_value->Set("boolean", base::Value::CreateBooleanValue(true));
+ param_object_value->Set("boolean", new base::FundamentalValue(true));
params_value->Append(param_object_value.release());
scoped_ptr<TestTypeInObject::Params> params(
TestTypeInObject::Params::Create(*params_value));
@@ -91,7 +90,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
scoped_ptr<base::ListValue> params_value(new base::ListValue());
scoped_ptr<base::DictionaryValue> param_object_value(
new base::DictionaryValue());
- param_object_value->Set("boolean", base::Value::CreateBooleanValue(true));
+ param_object_value->Set("boolean", new base::FundamentalValue(true));
params_value->Append(param_object_value.release());
scoped_ptr<TestTypeInObject::Params> params(
TestTypeInObject::Params::Create(*params_value));
@@ -105,7 +104,7 @@ TEST(JsonSchemaCompilerCrossrefTest, TestTypeInObjectParamsCreate) {
new base::DictionaryValue());
param_object_value->Set("testType",
base::Value::CreateStringValue("invalid"));
- param_object_value->Set("boolean", base::Value::CreateBooleanValue(true));
+ param_object_value->Set("boolean", new base::FundamentalValue(true));
params_value->Append(param_object_value.release());
scoped_ptr<TestTypeInObject::Params> params(
TestTypeInObject::Params::Create(*params_value));
« no previous file with comments | « tools/json_schema_compiler/test/choices_unittest.cc ('k') | tools/json_schema_compiler/test/objects_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698