chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/cloud_policy_browsertest.cc ('k') | chrome/browser/policy/javascript_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

diff --git a/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc b/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

index 4cb28ba614cf661e8df7f2f96985af57132e18e1..8392ff94dc8ce3e95c997bb79ab671d100ea8ef6 100644

--- a/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

+++ b/chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc

@@ -30,7 +30,7 @@ TEST_F(FileSelectionDialogsPolicyTest, EnableFileSelectionDialogs) {

policy_.Set(key::kAllowFileSelectionDialogs,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- base::Value::CreateBooleanValue(true),

+ new base::FundamentalValue(true),

NULL);

handler_.ApplyPolicySettings(policy_, &prefs_);

@@ -43,7 +43,7 @@ TEST_F(FileSelectionDialogsPolicyTest, DisableFileSelectionDialogs) {

policy_.Set(key::kAllowFileSelectionDialogs,

POLICY_LEVEL_MANDATORY,

POLICY_SCOPE_USER,

- base::Value::CreateBooleanValue(false),

+ new base::FundamentalValue(false),

NULL);

handler_.ApplyPolicySettings(policy_, &prefs_);