Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: tools/json_schema_compiler/test/simple_api_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « tools/json_schema_compiler/test/objects_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "tools/json_schema_compiler/test/simple_api.h" 5 #include "tools/json_schema_compiler/test/simple_api.h"
6 6
7 #include "testing/gtest/include/gtest/gtest.h" 7 #include "testing/gtest/include/gtest/gtest.h"
8 8
9 using namespace test::api::simple_api; 9 using namespace test::api::simple_api;
10 10
11 namespace { 11 namespace {
12 12
13 static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() { 13 static scoped_ptr<base::DictionaryValue> CreateTestTypeDictionary() {
14 scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue()); 14 scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
15 value->SetWithoutPathExpansion("number", 15 value->SetWithoutPathExpansion("number",
16 base::Value::CreateDoubleValue(1.1)); 16 base::Value::CreateDoubleValue(1.1));
17 value->SetWithoutPathExpansion("integer", new base::FundamentalValue(4)); 17 value->SetWithoutPathExpansion("integer", new base::FundamentalValue(4));
18 value->SetWithoutPathExpansion("string", 18 value->SetWithoutPathExpansion("string",
19 base::Value::CreateStringValue("bling")); 19 base::Value::CreateStringValue("bling"));
20 value->SetWithoutPathExpansion("boolean", 20 value->SetWithoutPathExpansion("boolean", new base::FundamentalValue(true));
21 base::Value::CreateBooleanValue(true));
22 return value.Pass(); 21 return value.Pass();
23 } 22 }
24 23
25 } // namespace 24 } // namespace
26 25
27 TEST(JsonSchemaCompilerSimpleTest, IncrementIntegerResultCreate) { 26 TEST(JsonSchemaCompilerSimpleTest, IncrementIntegerResultCreate) {
28 scoped_ptr<base::ListValue> results = IncrementInteger::Results::Create(5); 27 scoped_ptr<base::ListValue> results = IncrementInteger::Results::Create(5);
29 base::ListValue expected; 28 base::ListValue expected;
30 expected.Append(new base::FundamentalValue(5)); 29 expected.Append(new base::FundamentalValue(5));
31 EXPECT_TRUE(results->Equals(&expected)); 30 EXPECT_TRUE(results->Equals(&expected));
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
176 ASSERT_TRUE(expected->GetInteger("integer", &some_test_type.integer)); 175 ASSERT_TRUE(expected->GetInteger("integer", &some_test_type.integer));
177 ASSERT_TRUE(expected->GetBoolean("boolean", &some_test_type.boolean)); 176 ASSERT_TRUE(expected->GetBoolean("boolean", &some_test_type.boolean));
178 177
179 scoped_ptr<base::ListValue> results( 178 scoped_ptr<base::ListValue> results(
180 OnTestTypeFired::Create(some_test_type)); 179 OnTestTypeFired::Create(some_test_type));
181 base::DictionaryValue* result = NULL; 180 base::DictionaryValue* result = NULL;
182 results->GetDictionary(0, &result); 181 results->GetDictionary(0, &result);
183 EXPECT_TRUE(result->Equals(expected.get())); 182 EXPECT_TRUE(result->Equals(expected.get()));
184 } 183 }
185 } 184 }
OLDNEW
« no previous file with comments | « tools/json_schema_compiler/test/objects_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698