chrome/test/chromedriver/alert_commands.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/alert_commands.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/alert_commands.cc

diff --git a/chrome/test/chromedriver/alert_commands.cc b/chrome/test/chromedriver/alert_commands.cc

index de7118d5725a87abd720353901760ada3045b795..199e7bc4515bf1dc1e5b2035aa1ad6458294528f 100644

--- a/chrome/test/chromedriver/alert_commands.cc

+++ b/chrome/test/chromedriver/alert_commands.cc

@@ -44,7 +44,7 @@ Status ExecuteGetAlert(

WebView* web_view,

const base::DictionaryValue& params,

scoped_ptr<base::Value>* value) {

- value->reset(base::Value::CreateBooleanValue(

+ value->reset(new base::FundamentalValue(

web_view->GetJavaScriptDialogManager()->IsDialogOpen()));

return Status(kOk);

}