components/password_manager/core/browser/password_manager_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc ('k') | components/policy/core/browser/autofill_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_manager_unittest.cc b/components/password_manager/core/browser/password_manager_unittest.cc

index f1b5e33ce24ba12a7385d04781543c7a553ca038..f84e8bb6fa8eed0c34068ab29f281d3d349a49eb 100644

--- a/components/password_manager/core/browser/password_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_manager_unittest.cc

@@ -547,10 +547,10 @@ TEST_F(PasswordManagerTest, SavingDependsOnManagerEnabledPreference) {

// Test that saving passwords depends on the password manager enabled

// preference.

prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,

- base::Value::CreateBooleanValue(true));

+ new base::FundamentalValue(true));

EXPECT_TRUE(manager()->IsSavingEnabledForCurrentPage());

prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

EXPECT_FALSE(manager()->IsSavingEnabledForCurrentPage());

}

@@ -561,7 +561,7 @@ TEST_F(PasswordManagerTest, FillPasswordsOnDisabledManager) {

PasswordForm* existing = new PasswordForm(MakeSimpleForm());

result.push_back(existing);

prefs_.SetUserPref(prefs::kPasswordManagerSavingEnabled,

- base::Value::CreateBooleanValue(false));

+ new base::FundamentalValue(false));

EXPECT_CALL(driver_, FillPasswordForm(_));

EXPECT_CALL(*store_.get(),

GetLogins(_, testing::Eq(PasswordStore::DISALLOW_PROMPT), _))