Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/prefs/testing_pref_service.h" 10 #include "base/prefs/testing_pref_service.h"
(...skipping 259 matching lines...) Expand 10 before | Expand all | Expand 10 after
270 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) { 270 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyDisabled) {
271 TestCloudPrintProxyService service(&profile_); 271 TestCloudPrintProxyService service(&profile_);
272 272
273 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 273 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
274 MockServiceProcessControl::kServiceStateDisabled, false); 274 MockServiceProcessControl::kServiceStateDisabled, false);
275 275
276 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 276 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
277 prefs->SetUserPref(prefs::kCloudPrintEmail, 277 prefs->SetUserPref(prefs::kCloudPrintEmail,
278 base::Value::CreateStringValue(std::string())); 278 base::Value::CreateStringValue(std::string()));
279 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 279 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
280 base::Value::CreateBooleanValue(false)); 280 new base::FundamentalValue(false));
281 281
282 service.Initialize(); 282 service.Initialize();
283 283
284 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 284 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
285 } 285 }
286 286
287 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) { 287 TEST_F(CloudPrintProxyPolicyTest, StartWithPolicySetProxyEnabled) {
288 TestCloudPrintProxyService service(&profile_); 288 TestCloudPrintProxyService service(&profile_);
289 289
290 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 290 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
291 MockServiceProcessControl::kServiceStateEnabled, false); 291 MockServiceProcessControl::kServiceStateEnabled, false);
292 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 292 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
293 293
294 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 294 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
295 prefs->SetUserPref(prefs::kCloudPrintEmail, 295 prefs->SetUserPref(prefs::kCloudPrintEmail,
296 base::Value::CreateStringValue(std::string())); 296 base::Value::CreateStringValue(std::string()));
297 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 297 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
298 base::Value::CreateBooleanValue(false)); 298 new base::FundamentalValue(false));
299 299
300 service.Initialize(); 300 service.Initialize();
301 301
302 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 302 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
303 } 303 }
304 304
305 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) { 305 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenSetPolicy) {
306 TestCloudPrintProxyService service(&profile_); 306 TestCloudPrintProxyService service(&profile_);
307 307
308 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 308 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
309 MockServiceProcessControl::kServiceStateDisabled, false); 309 MockServiceProcessControl::kServiceStateDisabled, false);
310 310
311 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 311 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
312 prefs->SetUserPref(prefs::kCloudPrintEmail, 312 prefs->SetUserPref(prefs::kCloudPrintEmail,
313 base::Value::CreateStringValue( 313 base::Value::CreateStringValue(
314 MockServiceProcessControl::EnabledUserId())); 314 MockServiceProcessControl::EnabledUserId()));
315 315
316 service.Initialize(); 316 service.Initialize();
317 317
318 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 318 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
319 319
320 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 320 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
321 base::Value::CreateBooleanValue(false)); 321 new base::FundamentalValue(false));
322 322
323 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 323 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
324 } 324 }
325 325
326 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) { 326 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyEnabledThenSetPolicy) {
327 TestCloudPrintProxyService service(&profile_); 327 TestCloudPrintProxyService service(&profile_);
328 328
329 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 329 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
330 MockServiceProcessControl::kServiceStateEnabled, false); 330 MockServiceProcessControl::kServiceStateEnabled, false);
331 331
332 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 332 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
333 prefs->SetUserPref(prefs::kCloudPrintEmail, 333 prefs->SetUserPref(prefs::kCloudPrintEmail,
334 base::Value::CreateStringValue(std::string())); 334 base::Value::CreateStringValue(std::string()));
335 335
336 service.Initialize(); 336 service.Initialize();
337 service.RefreshStatusFromService(); 337 service.RefreshStatusFromService();
338 338
339 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(), 339 EXPECT_EQ(MockServiceProcessControl::EnabledUserId(),
340 prefs->GetString(prefs::kCloudPrintEmail)); 340 prefs->GetString(prefs::kCloudPrintEmail));
341 341
342 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 342 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
343 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 343 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
344 base::Value::CreateBooleanValue(false)); 344 new base::FundamentalValue(false));
345 345
346 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 346 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
347 } 347 }
348 348
349 TEST_F(CloudPrintProxyPolicyTest, 349 TEST_F(CloudPrintProxyPolicyTest,
350 StartWithPolicySetProxyDisabledThenClearPolicy) { 350 StartWithPolicySetProxyDisabledThenClearPolicy) {
351 TestCloudPrintProxyService service(&profile_); 351 TestCloudPrintProxyService service(&profile_);
352 352
353 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 353 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
354 MockServiceProcessControl::kServiceStateDisabled, false); 354 MockServiceProcessControl::kServiceStateDisabled, false);
355 355
356 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 356 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
357 prefs->SetUserPref(prefs::kCloudPrintEmail, 357 prefs->SetUserPref(prefs::kCloudPrintEmail,
358 base::Value::CreateStringValue(std::string())); 358 base::Value::CreateStringValue(std::string()));
359 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 359 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
360 base::Value::CreateBooleanValue(false)); 360 new base::FundamentalValue(false));
361 361
362 service.Initialize(); 362 service.Initialize();
363 363
364 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 364 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
365 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled); 365 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
366 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 366 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
367 } 367 }
368 368
369 TEST_F(CloudPrintProxyPolicyTest, 369 TEST_F(CloudPrintProxyPolicyTest,
370 StartWithPolicySetProxyEnabledThenClearPolicy) { 370 StartWithPolicySetProxyEnabledThenClearPolicy) {
371 TestCloudPrintProxyService service(&profile_); 371 TestCloudPrintProxyService service(&profile_);
372 372
373 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 373 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
374 MockServiceProcessControl::kServiceStateEnabled, false); 374 MockServiceProcessControl::kServiceStateEnabled, false);
375 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 375 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
376 376
377 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 377 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
378 prefs->SetUserPref(prefs::kCloudPrintEmail, 378 prefs->SetUserPref(prefs::kCloudPrintEmail,
379 base::Value::CreateStringValue(std::string())); 379 base::Value::CreateStringValue(std::string()));
380 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 380 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
381 base::Value::CreateBooleanValue(false)); 381 new base::FundamentalValue(false));
382 382
383 service.Initialize(); 383 service.Initialize();
384 384
385 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 385 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
386 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled); 386 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
387 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 387 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
388 } 388 }
389 389
390 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenEnable) { 390 TEST_F(CloudPrintProxyPolicyTest, StartWithNoPolicyProxyDisabledThenEnable) {
391 TestCloudPrintProxyService service(&profile_); 391 TestCloudPrintProxyService service(&profile_);
(...skipping 21 matching lines...) Expand all
413 TestCloudPrintProxyService service(&profile_); 413 TestCloudPrintProxyService service(&profile_);
414 414
415 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations( 415 service.GetMockServiceProcessControl()->SetConnectSuccessMockExpectations(
416 MockServiceProcessControl::kServiceStateEnabled, false); 416 MockServiceProcessControl::kServiceStateEnabled, false);
417 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations(); 417 service.GetMockServiceProcessControl()->SetWillBeDisabledExpectations();
418 418
419 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 419 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
420 prefs->SetUserPref(prefs::kCloudPrintEmail, 420 prefs->SetUserPref(prefs::kCloudPrintEmail,
421 base::Value::CreateStringValue(std::string())); 421 base::Value::CreateStringValue(std::string()));
422 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 422 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
423 base::Value::CreateBooleanValue(false)); 423 new base::FundamentalValue(false));
424 424
425 service.Initialize(); 425 service.Initialize();
426 426
427 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 427 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
428 service.EnableForUser(); 428 service.EnableForUser();
429 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 429 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
430 430
431 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled); 431 prefs->RemoveManagedPref(prefs::kCloudPrintProxyEnabled);
432 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail)); 432 EXPECT_EQ(std::string(), prefs->GetString(prefs::kCloudPrintEmail));
433 433
(...skipping 15 matching lines...) Expand all
449 449
450 service->Initialize(); 450 service->Initialize();
451 return service; 451 return service;
452 } 452 }
453 453
454 TEST_F(CloudPrintProxyPolicyTest, StartupBrowserCreatorWithCommandLine) { 454 TEST_F(CloudPrintProxyPolicyTest, StartupBrowserCreatorWithCommandLine) {
455 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService(); 455 TestingPrefServiceSyncable* prefs = profile_.GetTestingPrefService();
456 prefs->SetUserPref(prefs::kCloudPrintEmail, 456 prefs->SetUserPref(prefs::kCloudPrintEmail,
457 base::Value::CreateStringValue(std::string())); 457 base::Value::CreateStringValue(std::string()));
458 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled, 458 prefs->SetManagedPref(prefs::kCloudPrintProxyEnabled,
459 base::Value::CreateBooleanValue(false)); 459 new base::FundamentalValue(false));
460 460
461 CloudPrintProxyServiceFactory::GetInstance()-> 461 CloudPrintProxyServiceFactory::GetInstance()->
462 SetTestingFactory(&profile_, TestCloudPrintProxyServiceFactory); 462 SetTestingFactory(&profile_, TestCloudPrintProxyServiceFactory);
463 463
464 CommandLine command_line(CommandLine::NO_PROGRAM); 464 CommandLine command_line(CommandLine::NO_PROGRAM);
465 command_line.AppendSwitch(switches::kCheckCloudPrintConnectorPolicy); 465 command_line.AppendSwitch(switches::kCheckCloudPrintConnectorPolicy);
466 466
467 EXPECT_FALSE(LaunchBrowser(command_line, &profile_)); 467 EXPECT_FALSE(LaunchBrowser(command_line, &profile_));
468 base::RunLoop().RunUntilIdle(); 468 base::RunLoop().RunUntilIdle();
469 } 469 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698