Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: chromeos/dbus/shill_manager_client_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix bad merge Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "chromeos/dbus/shill_client_unittest_base.h" 7 #include "chromeos/dbus/shill_client_unittest_base.h"
8 #include "chromeos/dbus/shill_manager_client.h" 8 #include "chromeos/dbus/shill_manager_client.h"
9 #include "dbus/message.h" 9 #include "dbus/message.h"
10 #include "dbus/object_path.h" 10 #include "dbus/object_path.h"
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 dbus::MessageWriter entry_writer(NULL); 113 dbus::MessageWriter entry_writer(NULL);
114 array_writer.OpenDictEntry(&entry_writer); 114 array_writer.OpenDictEntry(&entry_writer);
115 entry_writer.AppendString(shill::kOfflineModeProperty); 115 entry_writer.AppendString(shill::kOfflineModeProperty);
116 entry_writer.AppendVariantOfBool(true); 116 entry_writer.AppendVariantOfBool(true);
117 array_writer.CloseContainer(&entry_writer); 117 array_writer.CloseContainer(&entry_writer);
118 writer.CloseContainer(&array_writer); 118 writer.CloseContainer(&array_writer);
119 119
120 // Create the expected value. 120 // Create the expected value.
121 base::DictionaryValue value; 121 base::DictionaryValue value;
122 value.SetWithoutPathExpansion(shill::kOfflineModeProperty, 122 value.SetWithoutPathExpansion(shill::kOfflineModeProperty,
123 base::Value::CreateBooleanValue(true)); 123 new base::FundamentalValue(true));
124 // Set expectations. 124 // Set expectations.
125 PrepareForMethodCall(shill::kGetPropertiesFunction, 125 PrepareForMethodCall(shill::kGetPropertiesFunction,
126 base::Bind(&ExpectNoArgument), 126 base::Bind(&ExpectNoArgument),
127 response.get()); 127 response.get());
128 // Call method. 128 // Call method.
129 client_->GetProperties(base::Bind(&ExpectDictionaryValueResult, &value)); 129 client_->GetProperties(base::Bind(&ExpectDictionaryValueResult, &value));
130 // Run the message loop. 130 // Run the message loop.
131 message_loop_.RunUntilIdle(); 131 message_loop_.RunUntilIdle();
132 } 132 }
133 133
(...skipping 297 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 arguments[7], 431 arguments[7],
432 base::Bind(&ExpectStringResultWithoutStatus, expected), 432 base::Bind(&ExpectStringResultWithoutStatus, expected),
433 mock_error_callback.GetCallback()); 433 mock_error_callback.GetCallback());
434 EXPECT_CALL(mock_error_callback, Run(_, _)).Times(0); 434 EXPECT_CALL(mock_error_callback, Run(_, _)).Times(0);
435 435
436 // Run the message loop. 436 // Run the message loop.
437 message_loop_.RunUntilIdle(); 437 message_loop_.RunUntilIdle();
438 } 438 }
439 439
440 } // namespace chromeos 440 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/dbus/shill_device_client_unittest.cc ('k') | chromeos/dbus/shill_profile_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698