chrome/browser/sync/sync_policy_handler_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Side by Side Diff: chrome/browser/sync/sync_policy_handler_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/prefs/pref_value_map.h"	5 #include "base/prefs/pref_value_map.h"

6 #include "base/values.h"	6 #include "base/values.h"

7 #include "chrome/browser/sync/sync_policy_handler.h"	7 #include "chrome/browser/sync/sync_policy_handler.h"

8 #include "components/policy/core/common/policy_map.h"	8 #include "components/policy/core/common/policy_map.h"

9 #include "components/sync_driver/pref_names.h"	9 #include "components/sync_driver/pref_names.h"

10 #include "policy/policy_constants.h"	10 #include "policy/policy_constants.h"

(...skipping 10 matching lines...) Expand all Loading...
21 PrefValueMap prefs;	21 PrefValueMap prefs;

22 handler.ApplyPolicySettings(policy, &prefs);	22 handler.ApplyPolicySettings(policy, &prefs);

23 EXPECT_FALSE(prefs.GetValue(sync_driver::prefs::kSyncManaged, NULL));	23 EXPECT_FALSE(prefs.GetValue(sync_driver::prefs::kSyncManaged, NULL));

24 }	24 }

25	25

26 TEST_F(SyncPolicyHandlerTest, Enabled) {	26 TEST_F(SyncPolicyHandlerTest, Enabled) {

27 policy::PolicyMap policy;	27 policy::PolicyMap policy;

28 policy.Set(policy::key::kSyncDisabled,	28 policy.Set(policy::key::kSyncDisabled,

29 policy::POLICY_LEVEL_MANDATORY,	29 policy::POLICY_LEVEL_MANDATORY,

30 policy::POLICY_SCOPE_USER,	30 policy::POLICY_SCOPE_USER,

31 base::Value::CreateBooleanValue(false),	31 new base::FundamentalValue(false),

32 NULL);	32 NULL);

33 SyncPolicyHandler handler;	33 SyncPolicyHandler handler;

34 PrefValueMap prefs;	34 PrefValueMap prefs;

35 handler.ApplyPolicySettings(policy, &prefs);	35 handler.ApplyPolicySettings(policy, &prefs);

36	36

37 // Enabling Sync should not set the pref.	37 // Enabling Sync should not set the pref.

38 EXPECT_FALSE(prefs.GetValue(sync_driver::prefs::kSyncManaged, NULL));	38 EXPECT_FALSE(prefs.GetValue(sync_driver::prefs::kSyncManaged, NULL));

39 }	39 }

40	40

41 TEST_F(SyncPolicyHandlerTest, Disabled) {	41 TEST_F(SyncPolicyHandlerTest, Disabled) {

42 policy::PolicyMap policy;	42 policy::PolicyMap policy;

43 policy.Set(policy::key::kSyncDisabled,	43 policy.Set(policy::key::kSyncDisabled,

44 policy::POLICY_LEVEL_MANDATORY,	44 policy::POLICY_LEVEL_MANDATORY,

45 policy::POLICY_SCOPE_USER,	45 policy::POLICY_SCOPE_USER,

46 base::Value::CreateBooleanValue(true),	46 new base::FundamentalValue(true),

47 NULL);	47 NULL);

48 SyncPolicyHandler handler;	48 SyncPolicyHandler handler;

49 PrefValueMap prefs;	49 PrefValueMap prefs;

50 handler.ApplyPolicySettings(policy, &prefs);	50 handler.ApplyPolicySettings(policy, &prefs);

51	51

52 // Sync should be flagged as managed.	52 // Sync should be flagged as managed.

53 const base::Value* value = NULL;	53 const base::Value* value = NULL;

54 EXPECT_TRUE(prefs.GetValue(sync_driver::prefs::kSyncManaged, &value));	54 EXPECT_TRUE(prefs.GetValue(sync_driver::prefs::kSyncManaged, &value));

55 ASSERT_TRUE(value);	55 ASSERT_TRUE(value);

56 bool sync_managed = false;	56 bool sync_managed = false;

57 bool result = value->GetAsBoolean(&sync_managed);	57 bool result = value->GetAsBoolean(&sync_managed);

58 ASSERT_TRUE(result);	58 ASSERT_TRUE(result);

59 EXPECT_TRUE(sync_managed);	59 EXPECT_TRUE(sync_managed);

60 }	60 }

61	61

62 } // namespace browser_sync	62 } // namespace browser_sync

OLD	NEW