components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chromeos/dbus/shill_profile_client_unittest.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc

diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc

index 115f780fa47657c83e21ec57863a13250d0aabc5..e59a0af5f6f57daf788b918ba20b882feeca1c2b 100644

--- a/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc

+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_settings_test_utils.cc

@@ -269,7 +269,7 @@ void DataReductionProxySettingsTestBase::CheckOnPrefChange(

expected_enabled ? 1 : 0);

if (managed) {

pref_service_.SetManagedPref(prefs::kDataReductionProxyEnabled,

- base::Value::CreateBooleanValue(enabled));

+ new base::FundamentalValue(enabled));

} else {

pref_service_.SetBoolean(prefs::kDataReductionProxyEnabled, enabled);

}