chrome/browser/prefs/pref_hash_calculator_unittest.cc - Issue 397793002: Eliminate CreateBooleanValue from test files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/pref_hash_calculator_unittest.cc

Issue 397793002: Eliminate CreateBooleanValue from test files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix bad merge Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prefs/pref_hash_calculator_unittest.cc

diff --git a/chrome/browser/prefs/pref_hash_calculator_unittest.cc b/chrome/browser/prefs/pref_hash_calculator_unittest.cc

index f8a44bd3fbc24bca4242bb54858d95735d59f0e4..356cc56a7866f19801ce033b038d70d8dde979fc 100644

--- a/chrome/browser/prefs/pref_hash_calculator_unittest.cc

+++ b/chrome/browser/prefs/pref_hash_calculator_unittest.cc

@@ -81,7 +81,7 @@ TEST(PrefHashCalculatorTest, CatchHashChanges) {

static const char kDeviceId[] = "test_device_id1";

scoped_ptr<base::Value> null_value(base::Value::CreateNullValue());

- scoped_ptr<base::Value> bool_value(base::Value::CreateBooleanValue(false));

+ scoped_ptr<base::Value> bool_value(new base::FundamentalValue(false));

scoped_ptr<base::Value> int_value(

base::Value::CreateIntegerValue(1234567890));

scoped_ptr<base::Value> double_value(